Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java

Issue 2873843004: Image Capture Android: make torch mode override other fill light mode(s) (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
diff --git a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
index 80b233fb1d213a4b3c86630ff6a0e2cb2f6a4b86..30ada12bb40950d450f024753fad7042a2f18a00 100644
--- a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
+++ b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
@@ -708,24 +708,24 @@ public class VideoCaptureCamera
}
}
- if (parameters.getSupportedFlashModes() != null
- && fillLightMode != AndroidFillLightMode.NOT_SET) {
- switch (fillLightMode) {
- case AndroidFillLightMode.OFF:
- parameters.setFlashMode(android.hardware.Camera.Parameters.FLASH_MODE_OFF);
- break;
- case AndroidFillLightMode.AUTO:
- parameters.setFlashMode(hasRedEyeReduction && redEyeReduction
- ? android.hardware.Camera.Parameters.FLASH_MODE_RED_EYE
- : android.hardware.Camera.Parameters.FLASH_MODE_AUTO);
- break;
- case AndroidFillLightMode.FLASH:
- parameters.setFlashMode(android.hardware.Camera.Parameters.FLASH_MODE_ON);
- break;
- default:
- }
+ if (parameters.getSupportedFlashModes() != null) {
if (hasTorch && torch) {
parameters.setFlashMode(android.hardware.Camera.Parameters.FLASH_MODE_TORCH);
+ } else if (fillLightMode != AndroidFillLightMode.NOT_SET) {
+ switch (fillLightMode) {
+ case AndroidFillLightMode.OFF:
+ parameters.setFlashMode(android.hardware.Camera.Parameters.FLASH_MODE_OFF);
+ break;
+ case AndroidFillLightMode.AUTO:
+ parameters.setFlashMode(hasRedEyeReduction && redEyeReduction
+ ? android.hardware.Camera.Parameters.FLASH_MODE_RED_EYE
+ : android.hardware.Camera.Parameters.FLASH_MODE_AUTO);
+ break;
+ case AndroidFillLightMode.FLASH:
+ parameters.setFlashMode(android.hardware.Camera.Parameters.FLASH_MODE_ON);
+ break;
+ default:
+ }
}
}
« no previous file with comments | « no previous file | media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698