Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2870243002: Revert of Adding BrowsingInstance verification to test of chrome.windows.create API. (Closed)

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding BrowsingInstance verification to test of chrome.windows.create API. (patchset #1 id:1 of https://codereview.chromium.org/2873693003/ ) Reason for revert: The modified test became flaky. Original issue's description: > Adding BrowsingInstance verification to test of chrome.windows.create API. > > BUG=597750 > > Review-Url: https://codereview.chromium.org/2873693003 > Cr-Commit-Position: refs/heads/master@{#470409} > Committed: https://chromium.googlesource.com/chromium/src/+/35b5da108fd0ae4c66c7665a09d0a3d682ce25e5 TBR=lazyboy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597750 Review-Url: https://codereview.chromium.org/2870243002 Cr-Commit-Position: refs/heads/master@{#470433} Committed: https://chromium.googlesource.com/chromium/src/+/e89c6ad74ad87fc5c2707c9c0247e00cd80f6dc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_test.cc View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Łukasz Anforowicz
Created Revert of Adding BrowsingInstance verification to test of chrome.windows.create API.
3 years, 7 months ago (2017-05-09 23:02:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870243002/1
3 years, 7 months ago (2017-05-09 23:05:21 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 23:06:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e89c6ad74ad87fc5c2707c9c0247...

Powered by Google App Engine
This is Rietveld 408576698