Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2873603002:
Update ICU to 59.1 (Closed)
|
Created:
3 years, 7 months ago by jungshik at Google Modified:
3 years, 7 months ago CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate ICU to 59.1
For details on what's new and changed in ICU 59.1, see
https://chromium-review.googlesource.com/c/505173/
On all platforms, ICU data size is increased by ~ 42 kB.
Inside ICU, UChar is typedef'd to be char16_t. Externally, it's
either uint16_t (non-Windows) or WChar (Windows) for now (i.e.
UChar is the same type as base::char16). This way, the minimal
amount of changes is necessary in Chromium, Blink and v8.
See https://bugs.chromium.org/p/v8/issues/detail?id=6062
https://bugs.chromium.org/p/chromium/issues/detail?id=693640
for changes made to work with ICU 59.1.
V8 was confirmed to pass all tests at
https://chromium-review.googlesource.com/c/505255 .
In addition, enable SymbolsIteratorTest.Emoji5AdditionsExceptFlags
(blink_platform_unittests).
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel
BUG=699469
TEST=blink layout tests, all *unittests including webkit,blink*, browsertests
TBR=drott@chromium.org, yangguo@chromium.org,michaeldo@chromium.org
Review-Url: https://codereview.chromium.org/2873603002
Cr-Commit-Position: refs/heads/master@{#471620}
Committed: https://chromium.googlesource.com/chromium/src/+/ee36babf91a54379889370cdd207e818555acb5d
Patch Set 1 #Patch Set 2 : For testing, roll v8 to 738ba5ef1 #Patch Set 3 : roll icu to f00b0c4; msvc C4229 warning fix #Patch Set 4 : rebased #Patch Set 5 : roll icu to ac66100e4291: fix an ICU bug 13190 #Patch Set 6 : roll icu to a8f633d (fix icu bug 13192) #Patch Set 7 : roll icu to ICU 59.1 in deps/icu master (instead of 59staging branch) #Patch Set 8 : Enable SymbolsIteratorTest.Emoji5AdditionsExceptFlags #
Total comments: 1
Messages
Total messages: 49 (43 generated)
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jshin@chromium.org
Description was changed from ========== Update ICU to 59.1 It requires the following v8 change: https://chromium-review.googlesource.com/c/499609/ BUG=699469 TEST=blink layout tests, *unittests, ========== to ========== Update ICU to 59.1 It requires the following v8 change: https://chromium-review.googlesource.com/c/499609/ CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel BUG=699469 TEST=blink layout tests, *unittests, ==========
Description was changed from ========== Update ICU to 59.1 It requires the following v8 change: https://chromium-review.googlesource.com/c/499609/ CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel BUG=699469 TEST=blink layout tests, *unittests, ========== to ========== Update ICU to 59.1 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel;master.tryserver.v8:v8_linux64_rel_ng,v8_win64_rel_ng,v8_mac_rel_ng BUG=699469 TEST=blink layout tests, *unittests, ==========
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/25767) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/22316) v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/27348)
Description was changed from ========== Update ICU to 59.1 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel;master.tryserver.v8:v8_linux64_rel_ng,v8_win64_rel_ng,v8_mac_rel_ng BUG=699469 TEST=blink layout tests, *unittests, ========== to ========== Update ICU to 59.1 For testing, roll v8 to 738ba5ef1. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel;master.tryserver.v8:v8_linux64_rel_ng,v8_win64_rel_ng,v8_mac_rel_ng BUG=699469 TEST=blink layout tests, *unittests, ==========
Description was changed from ========== Update ICU to 59.1 For testing, roll v8 to 738ba5ef1. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel;master.tryserver.v8:v8_linux64_rel_ng,v8_win64_rel_ng,v8_mac_rel_ng BUG=699469 TEST=blink layout tests, *unittests, ========== to ========== Update ICU to 59.1 For testing, roll v8 to 738ba5ef1, which includes a V8-side fix for ICU 59.1. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel;master.tryserver.v8:v8_linux64_rel_ng,v8_win64_rel_ng,v8_mac_rel_ng BUG=699469 TEST=blink layout tests, *unittests, ==========
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/22318)
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/22415)
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/22417)
Description was changed from ========== Update ICU to 59.1 For testing, roll v8 to 738ba5ef1, which includes a V8-side fix for ICU 59.1. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel;master.tryserver.v8:v8_linux64_rel_ng,v8_win64_rel_ng,v8_mac_rel_ng BUG=699469 TEST=blink layout tests, *unittests, ========== to ========== Update ICU to 59.1 For testing, roll v8 to 738ba5ef1, which includes a V8-side fix for ICU 59.1. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, *unittests, ==========
Description was changed from ========== Update ICU to 59.1 For testing, roll v8 to 738ba5ef1, which includes a V8-side fix for ICU 59.1. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, *unittests, ========== to ========== Update ICU to 59.1 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, *unittests, ==========
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac10.12_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac10.12_blink_rel/build...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Update ICU to 59.1 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, *unittests, ========== to ========== Update ICU to 59.1 For details on what's new and changed in ICU 59.1, see https://chromium-review.googlesource.com/c/505173/ On all platforms, ICU data size is increased by ~ 42 kB. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, all *unittests, browsertests TBR=drott@chromium.org, yangguo@chromium.org ==========
Description was changed from ========== Update ICU to 59.1 For details on what's new and changed in ICU 59.1, see https://chromium-review.googlesource.com/c/505173/ On all platforms, ICU data size is increased by ~ 42 kB. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, all *unittests, browsertests TBR=drott@chromium.org, yangguo@chromium.org ========== to ========== Update ICU to 59.1 For details on what's new and changed in ICU 59.1, see https://chromium-review.googlesource.com/c/505173/ On all platforms, ICU data size is increased by ~ 42 kB. Inside ICU, UChar is typedef'd to be char16_t. Externally, it's either uint16_t (non-Windows) or WChar (Windows) for now (i.e. UChar is the same type as base::char16). This way, the minimal amount of changes is necessary in Chromium, Blink and v8. See https://bugs.chromium.org/p/v8/issues/detail?id=6062 https://bugs.chromium.org/p/chromium/issues/detail?id=693640 for changes made to work with ICU 59.1. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, all *unittests, browsertests TBR=drott@chromium.org, yangguo@chromium.org ==========
Description was changed from ========== Update ICU to 59.1 For details on what's new and changed in ICU 59.1, see https://chromium-review.googlesource.com/c/505173/ On all platforms, ICU data size is increased by ~ 42 kB. Inside ICU, UChar is typedef'd to be char16_t. Externally, it's either uint16_t (non-Windows) or WChar (Windows) for now (i.e. UChar is the same type as base::char16). This way, the minimal amount of changes is necessary in Chromium, Blink and v8. See https://bugs.chromium.org/p/v8/issues/detail?id=6062 https://bugs.chromium.org/p/chromium/issues/detail?id=693640 for changes made to work with ICU 59.1. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, all *unittests, browsertests TBR=drott@chromium.org, yangguo@chromium.org ========== to ========== Update ICU to 59.1 For details on what's new and changed in ICU 59.1, see https://chromium-review.googlesource.com/c/505173/ On all platforms, ICU data size is increased by ~ 42 kB. Inside ICU, UChar is typedef'd to be char16_t. Externally, it's either uint16_t (non-Windows) or WChar (Windows) for now (i.e. UChar is the same type as base::char16). This way, the minimal amount of changes is necessary in Chromium, Blink and v8. See https://bugs.chromium.org/p/v8/issues/detail?id=6062 https://bugs.chromium.org/p/chromium/issues/detail?id=693640 for changes made to work with ICU 59.1. V8 is tested separately at https://chromium-review.googlesource.com/c/505255 . CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, all *unittests, browsertests TBR=drott@chromium.org, yangguo@chromium.org ==========
jshin@chromium.org changed reviewers: + drott@chromium.org, yangguo@chromium.org
Will add to CQ.
Description was changed from ========== Update ICU to 59.1 For details on what's new and changed in ICU 59.1, see https://chromium-review.googlesource.com/c/505173/ On all platforms, ICU data size is increased by ~ 42 kB. Inside ICU, UChar is typedef'd to be char16_t. Externally, it's either uint16_t (non-Windows) or WChar (Windows) for now (i.e. UChar is the same type as base::char16). This way, the minimal amount of changes is necessary in Chromium, Blink and v8. See https://bugs.chromium.org/p/v8/issues/detail?id=6062 https://bugs.chromium.org/p/chromium/issues/detail?id=693640 for changes made to work with ICU 59.1. V8 is tested separately at https://chromium-review.googlesource.com/c/505255 . CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, all *unittests, browsertests TBR=drott@chromium.org, yangguo@chromium.org ========== to ========== Update ICU to 59.1 For details on what's new and changed in ICU 59.1, see https://chromium-review.googlesource.com/c/505173/ On all platforms, ICU data size is increased by ~ 42 kB. Inside ICU, UChar is typedef'd to be char16_t. Externally, it's either uint16_t (non-Windows) or WChar (Windows) for now (i.e. UChar is the same type as base::char16). This way, the minimal amount of changes is necessary in Chromium, Blink and v8. See https://bugs.chromium.org/p/v8/issues/detail?id=6062 https://bugs.chromium.org/p/chromium/issues/detail?id=693640 for changes made to work with ICU 59.1. V8 was confirmed to pass all tests at https://chromium-review.googlesource.com/c/505255 . In addition, enable SymbolsIteratorTest.Emoji5AdditionsExceptFlags (blink_platform_unittests). CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, all *unittests including webkit,blink*, browsertests TBR=drott@chromium.org, yangguo@chromium.org ==========
Description was changed from ========== Update ICU to 59.1 For details on what's new and changed in ICU 59.1, see https://chromium-review.googlesource.com/c/505173/ On all platforms, ICU data size is increased by ~ 42 kB. Inside ICU, UChar is typedef'd to be char16_t. Externally, it's either uint16_t (non-Windows) or WChar (Windows) for now (i.e. UChar is the same type as base::char16). This way, the minimal amount of changes is necessary in Chromium, Blink and v8. See https://bugs.chromium.org/p/v8/issues/detail?id=6062 https://bugs.chromium.org/p/chromium/issues/detail?id=693640 for changes made to work with ICU 59.1. V8 was confirmed to pass all tests at https://chromium-review.googlesource.com/c/505255 . In addition, enable SymbolsIteratorTest.Emoji5AdditionsExceptFlags (blink_platform_unittests). CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, all *unittests including webkit,blink*, browsertests TBR=drott@chromium.org, yangguo@chromium.org ========== to ========== Update ICU to 59.1 For details on what's new and changed in ICU 59.1, see https://chromium-review.googlesource.com/c/505173/ On all platforms, ICU data size is increased by ~ 42 kB. Inside ICU, UChar is typedef'd to be char16_t. Externally, it's either uint16_t (non-Windows) or WChar (Windows) for now (i.e. UChar is the same type as base::char16). This way, the minimal amount of changes is necessary in Chromium, Blink and v8. See https://bugs.chromium.org/p/v8/issues/detail?id=6062 https://bugs.chromium.org/p/chromium/issues/detail?id=693640 for changes made to work with ICU 59.1. V8 was confirmed to pass all tests at https://chromium-review.googlesource.com/c/505255 . In addition, enable SymbolsIteratorTest.Emoji5AdditionsExceptFlags (blink_platform_unittests). CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, all *unittests including webkit,blink*, browsertests TBR=drott@chromium.org, yangguo@chromium.org,michaeldo@chromium.org ==========
jshin@chromium.org changed reviewers: + michaeldo@chromium.org
The CQ bit was checked by jshin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1494738670086890,
"parent_rev": "dbbb4e564b1412421f3a7b70cd8fa267581b3dea", "commit_rev":
"ee36babf91a54379889370cdd207e818555acb5d"}
Message was sent while issue was closed.
Description was changed from ========== Update ICU to 59.1 For details on what's new and changed in ICU 59.1, see https://chromium-review.googlesource.com/c/505173/ On all platforms, ICU data size is increased by ~ 42 kB. Inside ICU, UChar is typedef'd to be char16_t. Externally, it's either uint16_t (non-Windows) or WChar (Windows) for now (i.e. UChar is the same type as base::char16). This way, the minimal amount of changes is necessary in Chromium, Blink and v8. See https://bugs.chromium.org/p/v8/issues/detail?id=6062 https://bugs.chromium.org/p/chromium/issues/detail?id=693640 for changes made to work with ICU 59.1. V8 was confirmed to pass all tests at https://chromium-review.googlesource.com/c/505255 . In addition, enable SymbolsIteratorTest.Emoji5AdditionsExceptFlags (blink_platform_unittests). CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, all *unittests including webkit,blink*, browsertests TBR=drott@chromium.org, yangguo@chromium.org,michaeldo@chromium.org ========== to ========== Update ICU to 59.1 For details on what's new and changed in ICU 59.1, see https://chromium-review.googlesource.com/c/505173/ On all platforms, ICU data size is increased by ~ 42 kB. Inside ICU, UChar is typedef'd to be char16_t. Externally, it's either uint16_t (non-Windows) or WChar (Windows) for now (i.e. UChar is the same type as base::char16). This way, the minimal amount of changes is necessary in Chromium, Blink and v8. See https://bugs.chromium.org/p/v8/issues/detail?id=6062 https://bugs.chromium.org/p/chromium/issues/detail?id=693640 for changes made to work with ICU 59.1. V8 was confirmed to pass all tests at https://chromium-review.googlesource.com/c/505255 . In addition, enable SymbolsIteratorTest.Emoji5AdditionsExceptFlags (blink_platform_unittests). CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel BUG=699469 TEST=blink layout tests, all *unittests including webkit,blink*, browsertests TBR=drott@chromium.org, yangguo@chromium.org,michaeldo@chromium.org Review-Url: https://codereview.chromium.org/2873603002 Cr-Commit-Position: refs/heads/master@{#471620} Committed: https://chromium.googlesource.com/chromium/src/+/ee36babf91a54379889370cdd207... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://chromium.googlesource.com/chromium/src/+/ee36babf91a54379889370cdd207...
Message was sent while issue was closed.
Nice, thanks for working on the ICU roll. LGTM! https://codereview.chromium.org/2873603002/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp (right): https://codereview.chromium.org/2873603002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp:231: TEST_F(SymbolsIteratorTest, Emoji5AdditionsExceptFlags) { Thank you!
Message was sent while issue was closed.
lgtm |
