Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

Issue 2873603002: Update ICU to 59.1 (Closed)
Patch Set: Enable SymbolsIteratorTest.Emoji5AdditionsExceptFlags Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp b/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp
index 8fbc26a942f2b34974fd3ed9327e26b92ffe8a98..04ff8c832651b9ab69da3367efa7593abea3347b 100644
--- a/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp
+++ b/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp
@@ -223,13 +223,12 @@ TEST_F(SymbolsIteratorTest, JudgePilot) {
}
// Extracted from http://unicode.org/emoji/charts/emoji-released.html for Emoji
-// v5.0, except for the subdivision-flag section. Currently blocked on ICU 59
-// upgrade, TODO(jshin): crbug.com/699469
+// v5.0, except for the subdivision-flag section.
// Before ICU 59 new emoji sequences and new single emoji are not detected as
// emoji type text and sequences get split up in the middle so that shaping
// cannot form the right glyph from the emoji font. Running this as one run in
// one test ensures that the new emoji form an unbroken emoji-type sequence.
-TEST_F(SymbolsIteratorTest, DISABLED_Emoji5AdditionsExceptFlags) {
+TEST_F(SymbolsIteratorTest, Emoji5AdditionsExceptFlags) {
drott 2017/05/15 06:31:18 Thank you!
CHECK_RUNS(
{{"\xF0\x9F\xA7\x94\xF0\x9F\x8F\xBB\xF0\x9F\xA7\x94\xF0\x9F\x8F\xBC\xF0"
"\x9F\xA7\x94\xF0\x9F\x8F\xBD\xF0\x9F\xA7\x94\xF0\x9F\x8F\xBE\xF0\x9F"
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698