Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2873513003: Reland of Ensure that builders that use goma strip absolute paths by default. (Closed)

Created:
3 years, 7 months ago by Dirk Pranke
Modified:
3 years, 7 months ago
CC:
chromium-reviews, nodir
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Ensure that builders that use goma strip absolute paths by default. (patchset #1 id:1 of https://codereview.chromium.org/2843403004/ ) Reason for revert: Relanding, since this was not a cause of the goma outage. Original issue's description: > Revert of Ensure that builders that use goma strip absolute paths by default. (patchset #1 id:1 of https://codereview.chromium.org/2837863005/ ) > > Reason for revert: > Reverting in case this is related to the goma errors in https://crbug.com/716089 > > Original issue's description: > > Ensure that builders that use goma strip absolute paths by default. > > > > This CL tweaks the MB configs so that any builder that is using goma > > also sets strip_absolute_paths_from_debug_symbols_by_default=true. > > This helps ensure that we get the best goma cache hit rate possible. > > We don't just make the default equal to use_goma=true because doing > > so may make it harder for devs to debug binaries, and we want devs > > to be able to both debug binaries and use goma by default; the > > tradeoff is that their builds are slightly slower. > > > > R=thakis@chromium.org, jochen@chromium.org > > BUG=603286, 712790 > > > > Review-Url: https://codereview.chromium.org/2837863005 > > Cr-Commit-Position: refs/heads/master@{#467574} > > Committed: https://chromium.googlesource.com/chromium/src/+/050dbe550d14e99ad4e83093d4f4e79642b9edc3 > > TBR=jochen@chromium.org,thakis@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=603286, 712790 > > Review-Url: https://codereview.chromium.org/2843403004 > Cr-Commit-Position: refs/heads/master@{#467769} > Committed: https://chromium.googlesource.com/chromium/src/+/999471957dc5cf51048b0b344c58925a2954d452 TBR=jochen@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603286, 712790 Review-Url: https://codereview.chromium.org/2873513003 Cr-Commit-Position: refs/heads/master@{#470369} Committed: https://chromium.googlesource.com/chromium/src/+/c7b0cf640eee349516d275dad1a00bd393ac8644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M tools/mb/mb_config.pyl View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dirk Pranke
Created Reland of Ensure that builders that use goma strip absolute paths by default.
3 years, 7 months ago (2017-05-09 00:59:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873513003/1
3 years, 7 months ago (2017-05-09 01:17:09 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/439092)
3 years, 7 months ago (2017-05-09 02:34:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873513003/1
3 years, 7 months ago (2017-05-09 15:18:21 UTC) #7
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-09 16:24:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c7b0cf640eee349516d275dad1a00bd393ac8644
3 years, 7 months ago (2017-05-09 17:36:57 UTC) #11
Dirk Pranke
3 years, 7 months ago (2017-05-10 00:35:16 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2874613002/ by dpranke@chromium.org.

The reason for reverting is: Speculatively reverting in case this is causing
goma crashes (see crbug.com/720074).

Powered by Google App Engine
This is Rietveld 408576698