DescriptionReland of Ensure that builders that use goma strip absolute paths by default. (patchset #1 id:1 of https://codereview.chromium.org/2843403004/ )
Reason for revert:
Relanding, since this was not a cause of the goma outage.
Original issue's description:
> Revert of Ensure that builders that use goma strip absolute paths by default. (patchset #1 id:1 of https://codereview.chromium.org/2837863005/ )
>
> Reason for revert:
> Reverting in case this is related to the goma errors in https://crbug.com/716089
>
> Original issue's description:
> > Ensure that builders that use goma strip absolute paths by default.
> >
> > This CL tweaks the MB configs so that any builder that is using goma
> > also sets strip_absolute_paths_from_debug_symbols_by_default=true.
> > This helps ensure that we get the best goma cache hit rate possible.
> > We don't just make the default equal to use_goma=true because doing
> > so may make it harder for devs to debug binaries, and we want devs
> > to be able to both debug binaries and use goma by default; the
> > tradeoff is that their builds are slightly slower.
> >
> > R=thakis@chromium.org, jochen@chromium.org
> > BUG=603286, 712790
> >
> > Review-Url: https://codereview.chromium.org/2837863005
> > Cr-Commit-Position: refs/heads/master@{#467574}
> > Committed: https://chromium.googlesource.com/chromium/src/+/050dbe550d14e99ad4e83093d4f4e79642b9edc3
>
> TBR=jochen@chromium.org,thakis@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=603286, 712790
>
> Review-Url: https://codereview.chromium.org/2843403004
> Cr-Commit-Position: refs/heads/master@{#467769}
> Committed: https://chromium.googlesource.com/chromium/src/+/999471957dc5cf51048b0b344c58925a2954d452
TBR=jochen@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=603286, 712790
Review-Url: https://codereview.chromium.org/2873513003
Cr-Commit-Position: refs/heads/master@{#470369}
Committed: https://chromium.googlesource.com/chromium/src/+/c7b0cf640eee349516d275dad1a00bd393ac8644
Patch Set 1 #
Messages
Total messages: 12 (5 generated)
|