build/config/compiler/BUILD.gn - Issue 2873513003: Reland of Ensure that builders that use goma strip absolute paths by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 2873513003: Reland of Ensure that builders that use goma strip absolute paths by default. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 6a495cc2a82b8b2500a5c7c0c5398b7389c8f0a3..2058a075da17a25022e2e1100d1f466e019d78b7 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -94,7 +94,9 @@

# branches)

optimize_for_fuzzing = false

- # Optimize symbol files for maximizing goma cache hit rate.

+ # Optimize symbol files for maximizing goma cache hit rate. This isn't

+ # on by default when goma is enabled because setting this to true may make

+ # it harder to debug binaries.

strip_absolute_paths_from_debug_symbols = false

}

« no previous file with comments | « no previous file | tools/mb/mb_config.pyl » ('j') | no next file with comments »