Fix dependencies on OutOfProcessPatcher.

Fix dependencies on OutOfProcessPatcher.

This is a mechanical change.

The component updater classes have dependencies on OutOfProcessPatcher.
Before this change, a client that needed to use the ComponentUnpacker
had to include component_patcher_operation.h.

With this change, the clients of ComponentUnpacker only need to include
component_unpacker.h

BUG=719751
Review-Url: https://codereview.chromium.org/2873513002
Cr-Commit-Position: refs/heads/master@{#471002}
Committed: https://chromium.googlesource.com/chromium/src/+/cca1c125366c60bc328af9697458aedd6c67aa17

[Sorin Jianu, 2017-05-08 23:41:20]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[Sorin Jianu, 2017-05-08 23:41:50]

Description was changed from

==========
Fix dependencies on OutOfProcessPatcher.

This is a mechanical change.

The component updater classes have dependencies on OutOfProcessPatcher.
Before this change, a client that needed to use the ComponentUnpacker
had to include component_patcher_operation.h.

With this change, the clients of ComponentUnpacker only need to include
component_unpacker.h

BUG=719751
==========

to

==========
Fix dependencies on OutOfProcessPatcher.

This is a mechanical change.

The component updater classes have dependencies on OutOfProcessPatcher.
Before this change, a client that needed to use the ComponentUnpacker
had to include component_patcher_operation.h.

With this change, the clients of ComponentUnpacker only need to include
component_unpacker.h

BUG=719751
==========

[Sorin Jianu, 2017-05-08 23:41:50]

sorin@chromium.org changed reviewers:
+ droger@chromium.org, waffles@chromium.org

[Sorin Jianu, 2017-05-08 23:43:11]

This is a mechanical change.

David, could you please take a look at changes for the ios paths?

Thank you!

[waffles, 2017-05-08 23:45:48]

lgtm

[Sorin Jianu, 2017-05-08 23:47:59]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 23:48:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 01:54:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:54:35]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sdefresne, 2017-05-09 08:22:10]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org
- droger@chromium.org

[sdefresne, 2017-05-09 08:23:12]

droger is OOO the whole week. I can do the review instead of him if you don't
mind.

https://codereview.chromium.org/2873513002/diff/20001/components/update_clien...
File components/update_client/out_of_process_patcher.h (right):

https://codereview.chromium.org/2873513002/diff/20001/components/update_clien...
components/update_client/out_of_process_patcher.h:15: namespace Base {
Base -> base

https://codereview.chromium.org/2873513002/diff/20001/ios/chrome/browser/comp...
File ios/chrome/browser/component_updater/ios_component_updater_configurator.cc
(right):

https://codereview.chromium.org/2873513002/diff/20001/ios/chrome/browser/comp...
ios/chrome/browser/component_updater/ios_component_updater_configurator.cc:177:
return base::MakeRefCounted<IOSConfigurator>(cmdline, context_getter);
MakeRefCounter -> MakeShared

[Sorin Jianu, 2017-05-09 17:28:47]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[Sorin Jianu, 2017-05-09 17:29:36]

Thank you! Could you please take another look?

[commit-bot: I haz the power, 2017-05-09 17:29:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sorin Jianu, 2017-05-09 17:30:09]

https://codereview.chromium.org/2873513002/diff/20001/components/update_clien...
File components/update_client/out_of_process_patcher.h (right):

https://codereview.chromium.org/2873513002/diff/20001/components/update_clien...
components/update_client/out_of_process_patcher.h:15: namespace Base {
On 2017/05/09 08:23:12, sdefresne wrote:
> Base -> base

Done.

https://codereview.chromium.org/2873513002/diff/20001/ios/chrome/browser/comp...
File ios/chrome/browser/component_updater/ios_component_updater_configurator.cc
(right):

https://codereview.chromium.org/2873513002/diff/20001/ios/chrome/browser/comp...
ios/chrome/browser/component_updater/ios_component_updater_configurator.cc:177:
return base::MakeRefCounted<IOSConfigurator>(cmdline, context_getter);
On 2017/05/09 08:23:12, sdefresne wrote:
> MakeRefCounter -> MakeShared

Done.

[commit-bot: I haz the power, 2017-05-09 17:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 17:39:45]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sdefresne, 2017-05-10 07:58:52]

https://codereview.chromium.org/2873513002/diff/40001/components/update_clien...
File components/update_client/out_of_process_patcher.h (right):

https://codereview.chromium.org/2873513002/diff/40001/components/update_clien...
components/update_client/out_of_process_patcher.h:8: namespace update_client {
Move this below the #include and the forward-declaration of the "base"
namespace.

[Sorin Jianu, 2017-05-10 18:50:34]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 18:52:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sorin Jianu, 2017-05-10 18:55:56]

The CQ bit was unchecked by sorin@chromium.org

[Sorin Jianu, 2017-05-10 19:07:54]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 19:09:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 19:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:20:35]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sorin Jianu, 2017-05-10 19:54:08]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 19:56:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 20:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 20:08:08]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Sorin Jianu, 2017-05-10 20:41:24]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 20:42:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 02:45:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 02:45:22]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_TIMED_OUT,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sorin Jianu, 2017-05-11 05:39:57]

Thank you! PTAL! I apologize for previous bad patches.

[sdefresne, 2017-05-11 09:59:24]

ios/ lgtm

[Sorin Jianu, 2017-05-11 17:32:55]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2017-05-11 17:32:55]

The patchset sent to the CQ was uploaded after l-g-t-m from waffles@chromium.org
Link to the patchset: https://codereview.chromium.org/2873513002/#ps140001
(title: "base namespace fix")

[commit-bot: I haz the power, 2017-05-11 17:33:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 17:43:25]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1494523975138450,
"parent_rev": "066e8c280fe7db54e8dcc2ac4db464592ac6cd19", "commit_rev":
"cca1c125366c60bc328af9697458aedd6c67aa17"}

[commit-bot: I haz the power, 2017-05-11 17:43:44]

Description was changed from

==========
Fix dependencies on OutOfProcessPatcher.

This is a mechanical change.

The component updater classes have dependencies on OutOfProcessPatcher.
Before this change, a client that needed to use the ComponentUnpacker
had to include component_patcher_operation.h.

With this change, the clients of ComponentUnpacker only need to include
component_unpacker.h

BUG=719751
==========

to

==========
Fix dependencies on OutOfProcessPatcher.

This is a mechanical change.

The component updater classes have dependencies on OutOfProcessPatcher.
Before this change, a client that needed to use the ComponentUnpacker
had to include component_patcher_operation.h.

With this change, the clients of ComponentUnpacker only need to include
component_unpacker.h

BUG=719751

Review-Url: https://codereview.chromium.org/2873513002
Cr-Commit-Position: refs/heads/master@{#471002}
Committed:
https://chromium.googlesource.com/chromium/src/+/cca1c125366c60bc328af9697458...
==========

[commit-bot: I haz the power, 2017-05-11 17:43:45]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/cca1c125366c60bc328af9697458...