Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: chrome/browser/component_updater/component_patcher_operation_out_of_process.cc

Issue 2873513002: Fix dependencies on OutOfProcessPatcher. (Closed)
Patch Set: base namespace fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/component_patcher_operation_out_of_process.cc
diff --git a/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc b/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc
index 9ba253d79af70021ffe129c5bd5cfc0062950ec0..5068cb52f89a0ce32e8f92fcebac105b56232c57 100644
--- a/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc
+++ b/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/component_updater/component_patcher_operation_out_of_process.h"
+#include <utility>
+
#include "base/bind.h"
#include "base/callback.h"
#include "base/files/file.h"
@@ -11,6 +13,7 @@
#include "base/sequenced_task_runner.h"
#include "base/strings/string16.h"
#include "chrome/grit/generated_resources.h"
+#include "components/update_client/component_patcher_operation.h"
#include "content/public/browser/browser_thread.h"
#include "ui/base/l10n/l10n_util.h"
@@ -22,15 +25,15 @@ ChromeOutOfProcessPatcher::~ChromeOutOfProcessPatcher() = default;
void ChromeOutOfProcessPatcher::Patch(
const std::string& operation,
- scoped_refptr<base::SequencedTaskRunner> task_runner,
+ const scoped_refptr<base::SequencedTaskRunner>& task_runner,
const base::FilePath& input_path,
const base::FilePath& patch_path,
const base::FilePath& output_path,
- base::Callback<void(int result)> callback) {
+ const base::Callback<void(int result)>& callback) {
DCHECK(task_runner);
DCHECK(!callback.is_null());
- task_runner_ = std::move(task_runner);
+ task_runner_ = task_runner;
callback_ = callback;
base::File input_file(input_path,
« no previous file with comments | « chrome/browser/component_updater/component_patcher_operation_out_of_process.h ('k') | components/update_client/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698