Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2873463002: Remove call to base::TaskTraits::WithPriority() in module_inspector_win.cc. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
Patrick Monette
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove call to base::TaskTraits::WithPriority() in module_inspector_win.cc. This method is deprecated. BUG=713683 Review-Url: https://codereview.chromium.org/2873463002 Cr-Commit-Position: refs/heads/master@{#470164} Committed: https://chromium.googlesource.com/chromium/src/+/95ee6bf2d209326f59dd26a08f53a8958c7a49e5

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR-pmonette-5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M chrome/browser/conflicts/module_inspector_win.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/conflicts/module_inspector_win.cc View 1 3 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
fdoray
PTAL
3 years, 7 months ago (2017-05-08 20:28:44 UTC) #3
Patrick Monette
https://codereview.chromium.org/2873463002/diff/1/chrome/browser/conflicts/module_inspector_win.h File chrome/browser/conflicts/module_inspector_win.h (right): https://codereview.chromium.org/2873463002/diff/1/chrome/browser/conflicts/module_inspector_win.h#newcode64 chrome/browser/conflicts/module_inspector_win.h:64: base::TaskPriority inspection_task_priority_ = base::TaskPriority::BACKGROUND; I prefer to have all ...
3 years, 7 months ago (2017-05-08 20:35:11 UTC) #5
fdoray
PTAnL https://codereview.chromium.org/2873463002/diff/1/chrome/browser/conflicts/module_inspector_win.h File chrome/browser/conflicts/module_inspector_win.h (right): https://codereview.chromium.org/2873463002/diff/1/chrome/browser/conflicts/module_inspector_win.h#newcode64 chrome/browser/conflicts/module_inspector_win.h:64: base::TaskPriority inspection_task_priority_ = base::TaskPriority::BACKGROUND; On 2017/05/08 20:35:11, Patrick ...
3 years, 7 months ago (2017-05-08 20:40:02 UTC) #7
Patrick Monette
lgtm
3 years, 7 months ago (2017-05-08 20:43:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873463002/20001
3 years, 7 months ago (2017-05-08 20:45:32 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 03:48:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/95ee6bf2d209326f59dd26a08f53...

Powered by Google App Engine
This is Rietveld 408576698