Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: chrome/browser/conflicts/module_inspector_win.h

Issue 2873463002: Remove call to base::TaskTraits::WithPriority() in module_inspector_win.cc. (Closed)
Patch Set: CR-pmonette-5 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/conflicts/module_inspector_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CONFLICTS_MODULE_INSPECTOR_WIN_H_ 5 #ifndef CHROME_BROWSER_CONFLICTS_MODULE_INSPECTOR_WIN_H_
6 #define CHROME_BROWSER_CONFLICTS_MODULE_INSPECTOR_WIN_H_ 6 #define CHROME_BROWSER_CONFLICTS_MODULE_INSPECTOR_WIN_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <queue> 9 #include <queue>
10 10
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 // for inspection. 52 // for inspection.
53 void OnInspectionFinished( 53 void OnInspectionFinished(
54 const ModuleInfoKey& module_key, 54 const ModuleInfoKey& module_key,
55 std::unique_ptr<ModuleInspectionResult> inspection_result); 55 std::unique_ptr<ModuleInspectionResult> inspection_result);
56 56
57 OnModuleInspectedCallback on_module_inspected_callback_; 57 OnModuleInspectedCallback on_module_inspected_callback_;
58 58
59 // The modules are put in queue until they are sent for inspection. 59 // The modules are put in queue until they are sent for inspection.
60 std::queue<ModuleInfoKey> queue_; 60 std::queue<ModuleInfoKey> queue_;
61 61
62 // The traits used on the task that inspects the modules. It originally starts 62 // The TaskPriority of the task that inspects the modules. It originally
63 // at a BACKGROUND priority, but is changed to USER_VISIBLE when 63 // starts at BACKGROUND priority, but is changed to USER_VISIBLE when
64 // IncreaseInspectionPriority() is called. 64 // IncreaseInspectionPriority() is called.
65 base::TaskTraits inspection_task_traits_; 65 base::TaskPriority inspection_task_priority_;
66 66
67 // The vector of paths to %env_var%, used to account for differences in 67 // The vector of paths to %env_var%, used to account for differences in
68 // localization and where people keep their files. 68 // localization and where people keep their files.
69 // e.g. c:\windows vs d:\windows 69 // e.g. c:\windows vs d:\windows
70 StringMapping path_mapping_; 70 StringMapping path_mapping_;
71 71
72 base::ThreadChecker thread_checker_; 72 base::ThreadChecker thread_checker_;
73 73
74 // Weak pointers are used to safely post the inspection result back to the 74 // Weak pointers are used to safely post the inspection result back to the
75 // ModuleInspector from the task scheduler. 75 // ModuleInspector from the task scheduler.
76 base::WeakPtrFactory<ModuleInspector> weak_ptr_factory_; 76 base::WeakPtrFactory<ModuleInspector> weak_ptr_factory_;
77 77
78 DISALLOW_COPY_AND_ASSIGN(ModuleInspector); 78 DISALLOW_COPY_AND_ASSIGN(ModuleInspector);
79 }; 79 };
80 80
81 #endif // CHROME_BROWSER_CONFLICTS_MODULE_INSPECTOR_WIN_H_ 81 #endif // CHROME_BROWSER_CONFLICTS_MODULE_INSPECTOR_WIN_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/conflicts/module_inspector_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698