Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issue 2873433005: cros: Move ash/login/views to ash/login/ui (Closed)

Created:
3 years, 7 months ago by jdufault
Modified:
3 years, 7 months ago
Reviewers:
xiyuan, James Cook
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Move ash/login/views to ash/login/ui This is a follow-up commit to https://codereview.chromium.org/2859363003/. BUG=719015 Review-Url: https://codereview.chromium.org/2873433005 Cr-Commit-Position: refs/heads/master@{#470693} Committed: https://chromium.googlesource.com/chromium/src/+/30c518245c94361d0eb5077e278782d49b9f9cd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -129 lines) Patch
M ash/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ash/login/ui/lock_contents_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/login/ui/lock_contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/login/ui/lock_screen.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/login/ui/lock_screen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D ash/login/views/lock_contents_view.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ash/login/views/lock_contents_view.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D ash/login/views/lock_screen.h View 1 chunk +0 lines, -23 lines 0 comments Download
D ash/login/views/lock_screen.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (17 generated)
jdufault
jamescook@ PTAL at ash, xiyuan@ PTAL at chrome. There are no real changes, just moves.
3 years, 7 months ago (2017-05-10 17:51:10 UTC) #13
James Cook
LGTM
3 years, 7 months ago (2017-05-10 19:25:34 UTC) #14
xiyuan
lgtm
3 years, 7 months ago (2017-05-10 19:29:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873433005/1
3 years, 7 months ago (2017-05-10 20:21:27 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 20:37:36 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/30c518245c94361d0eb5077e2787...

Powered by Google App Engine
This is Rietveld 408576698