cros: Move LockWindow from chrome to ash

cros: Move LockWindow from chrome to ash

The lock screen is moving from webui to views, and we need to instantiate the LockWindow inside of ash (since that is where the views code resides).

BUG=719015
Review-Url: https://codereview.chromium.org/2867173003
Cr-Commit-Position: refs/heads/master@{#470785}
Committed: https://chromium.googlesource.com/chromium/src/+/1b2f92e7444305d3132176edc5709b0805c9847a

[jdufault, 2017-05-08 23:42:02]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 23:48:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 01:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:21:06]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jdufault, 2017-05-09 17:34:46]

Description was changed from

==========
cros: Move LoginWindow from chrome to ash

BUG=
==========

to

==========
cros: Move LoginWindow from chrome to ash

BUG=719015
==========

[jdufault, 2017-05-09 17:37:35]

jdufault@chromium.org changed reviewers:
+ jamescook@chromium.org

[jdufault, 2017-05-09 17:37:44]

jamescook@ PTAL

[jdufault, 2017-05-09 17:38:02]

jdufault@chromium.org changed reviewers:
+ xiyuan@chromium.org

[jdufault, 2017-05-09 17:38:28]

On 2017/05/09 17:37:44, jdufault wrote:
> jamescook@ PTAL

sorry -

jamescook@ PTAL at ash/,
xiyuan@ PTAL at chrome/

[xiyuan, 2017-05-09 18:03:03]

The CL description says LoginWindow but the CL is about LockWindow. Please make
it consistent.

Do you want to rename ash/login/views -> ash/login/ui with the CL?

[jdufault, 2017-05-09 18:37:42]

Description was changed from

==========
cros: Move LoginWindow from chrome to ash

BUG=719015
==========

to

==========
cros: Move LockWindow from chrome to ash

BUG=719015
==========

[jdufault, 2017-05-09 18:38:22]

On 2017/05/09 18:03:03, xiyuan wrote:
> The CL description says LoginWindow but the CL is about LockWindow. Please
make
> it consistent.

Good catch - done.

> Do you want to rename ash/login/views -> ash/login/ui with the CL?

I have a follow-up CL to do that. I can merge it into this one if that's easier.

[xiyuan, 2017-05-09 19:02:03]

On 2017/05/09 18:38:22, jdufault wrote:
> On 2017/05/09 18:03:03, xiyuan wrote:
> > The CL description says LoginWindow but the CL is about LockWindow. Please
> make
> > it consistent.
> 
> Good catch - done.
> 
> > Do you want to rename ash/login/views -> ash/login/ui with the CL?
> 
> I have a follow-up CL to do that. I can merge it into this one if that's
easier.

It is fine as long as it is tracked.

lgtm

[James Cook, 2017-05-09 20:01:56]

Code LGTM but please move the file into ash/login/ui instead.

Also, please put a "why we did this" statement into your CL description. "Part
of the transition from webui to views-based lock screen" would be fine. This is
a pet peeve of mine - I know your motivation now, but when I run "git log" a
year from now I won't remember.

https://codereview.chromium.org/2867173003/diff/1/ash/login/views/lock_window.h
File ash/login/views/lock_window.h (right):

https://codereview.chromium.org/2867173003/diff/1/ash/login/views/lock_window...
ash/login/views/lock_window.h:5: #ifndef ASH_LOGIN_VIEWS_LOCK_WINDOW_H_
If you're going to move this file I would prefer that you move it into
ash/login/ui/ now, rather than moving it now and again later. This will make the
git history easier to follow.

tools/git/move_source_file.py FTW

[jdufault, 2017-05-09 21:07:42]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 21:09:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 21:30:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 21:30:40]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[jdufault, 2017-05-10 16:49:25]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 16:50:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 18:23:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 18:23:05]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-05-11 01:10:24]

Description was changed from

==========
cros: Move LockWindow from chrome to ash

BUG=719015
==========

to

==========
cros: Move LockWindow from chrome to ash

The lock screen is moving from webui to views, and we need to instantiate the
LockWindow inside of ash (since that is where the views code resides).

BUG=719015
==========

[jdufault, 2017-05-11 01:10:34]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-05-11 01:10:35]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2867173003/#ps20001
(title: "Reorder patches so view -> ui lands first")

[commit-bot: I haz the power, 2017-05-11 01:11:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 02:58:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494465034666140,
"parent_rev": "078d397a6b7af9a6a41edc55e2567fc7520b235c", "commit_rev":
"1b2f92e7444305d3132176edc5709b0805c9847a"}

[commit-bot: I haz the power, 2017-05-11 02:58:33]

Description was changed from

==========
cros: Move LockWindow from chrome to ash

The lock screen is moving from webui to views, and we need to instantiate the
LockWindow inside of ash (since that is where the views code resides).

BUG=719015
==========

to

==========
cros: Move LockWindow from chrome to ash

The lock screen is moving from webui to views, and we need to instantiate the
LockWindow inside of ash (since that is where the views code resides).

BUG=719015

Review-Url: https://codereview.chromium.org/2867173003
Cr-Commit-Position: refs/heads/master@{#470785}
Committed:
https://chromium.googlesource.com/chromium/src/+/1b2f92e7444305d3132176edc570...
==========

[commit-bot: I haz the power, 2017-05-11 02:58:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1b2f92e7444305d3132176edc570...