Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 287343003: Oilpan: fix failing animation unit tests. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: fix failing animation unit tests. Address three failures: * AnimationTest.ElementDestructorClearsAnimationTarget Animation objects now die with their target element, hence testing for it separately being destructed doesn't make sense in an Oilpan setting. * AnimationStackTest.ForwardsFillDiscarding In order to be able to accurately sample the number of effects on the stack, explicitly GC before querying. * AnimationPlayerTest.AttachedAnimationPlayers Use a persistent to correctly hold on to the test element. If not, the final GC will destruct it also & making any further testing over it invalid. R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Source/core/animation/AnimationPlayerTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/animation/AnimationStackTest.cpp View 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
Please take a look.
6 years, 7 months ago (2014-05-18 14:49:16 UTC) #1
haraken
LGTM. I'm sorry I didn't take care of those failures...
6 years, 7 months ago (2014-05-18 19:07:41 UTC) #2
sof
On 2014/05/18 19:07:41, haraken wrote: > LGTM. I'm sorry I didn't take care of those ...
6 years, 7 months ago (2014-05-18 19:54:25 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-18 19:54:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/287343003/1
6 years, 7 months ago (2014-05-18 19:55:11 UTC) #5
haraken
On 2014/05/18 19:54:25, sof wrote: > On 2014/05/18 19:07:41, haraken wrote: > > LGTM. I'm ...
6 years, 7 months ago (2014-05-18 21:59:49 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 10:09:34 UTC) #7
Message was sent while issue was closed.
Change committed as 174261

Powered by Google App Engine
This is Rietveld 408576698