Source/core/animation/AnimationStackTest.cpp - Issue 287343003: Oilpan: fix failing animation unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/AnimationStackTest.cpp

Issue 287343003: Oilpan: fix failing animation unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/animation/AnimationStackTest.cpp

diff --git a/Source/core/animation/AnimationStackTest.cpp b/Source/core/animation/AnimationStackTest.cpp

index 87a31178fe5c15f37aca7f5fb3285069a2b7aee0..333118fb98c223e9375ca21acc28c104e3633de5 100644

--- a/Source/core/animation/AnimationStackTest.cpp

+++ b/Source/core/animation/AnimationStackTest.cpp

@@ -126,6 +126,7 @@ TEST_F(AnimationAnimationStackTest, ForwardsFillDiscarding)

WillBeHeapHashMap<CSSPropertyID, RefPtrWillBeMember<Interpolation> > interpolations;

updateTimeline(11);

+ Heap::collectAllGarbage();

interpolations = AnimationStack::activeInterpolations(&element->activeAnimations()->defaultStack(), 0, 0, Animation::DefaultPriority, 0);

EXPECT_TRUE(interpolationValue(interpolations.get(CSSPropertyFontSize))->equals(AnimatableDouble::create(2).get()));

EXPECT_EQ(3u, effects().size());

@@ -135,6 +136,7 @@ TEST_F(AnimationAnimationStackTest, ForwardsFillDiscarding)

EXPECT_EQ(6, effects()[2]->sortInfo().startTime());

updateTimeline(13);

+ Heap::collectAllGarbage();

interpolations = AnimationStack::activeInterpolations(&element->activeAnimations()->defaultStack(), 0, 0, Animation::DefaultPriority, 0);

EXPECT_TRUE(interpolationValue(interpolations.get(CSSPropertyFontSize))->equals(AnimatableDouble::create(2).get()));

EXPECT_EQ(3u, effects().size());

@@ -143,6 +145,7 @@ TEST_F(AnimationAnimationStackTest, ForwardsFillDiscarding)

EXPECT_EQ(6, effects()[2]->sortInfo().startTime());

updateTimeline(15);

+ Heap::collectAllGarbage();

interpolations = AnimationStack::activeInterpolations(&element->activeAnimations()->defaultStack(), 0, 0, Animation::DefaultPriority, 0);

EXPECT_TRUE(interpolationValue(interpolations.get(CSSPropertyFontSize))->equals(AnimatableDouble::create(2).get()));

EXPECT_EQ(2u, effects().size());

@@ -150,6 +153,7 @@ TEST_F(AnimationAnimationStackTest, ForwardsFillDiscarding)

EXPECT_EQ(6, effects()[1]->sortInfo().startTime());

updateTimeline(17);

+ Heap::collectAllGarbage();

interpolations = AnimationStack::activeInterpolations(&element->activeAnimations()->defaultStack(), 0, 0, Animation::DefaultPriority, 0);

EXPECT_TRUE(interpolationValue(interpolations.get(CSSPropertyFontSize))->equals(AnimatableDouble::create(2).get()));

EXPECT_EQ(1u, effects().size());