Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: Source/core/animation/AnimationPlayerTest.cpp

Issue 287343003: Oilpan: fix failing animation unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/animation/AnimationStackTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/AnimationPlayerTest.cpp
diff --git a/Source/core/animation/AnimationPlayerTest.cpp b/Source/core/animation/AnimationPlayerTest.cpp
index c666a55f93a25eb91ef49b9a540286689ba2b91f..0f870d11882f194eda432c7132989b8cec408642 100644
--- a/Source/core/animation/AnimationPlayerTest.cpp
+++ b/Source/core/animation/AnimationPlayerTest.cpp
@@ -695,7 +695,7 @@ TEST_F(AnimationAnimationPlayerTest, TimeToNextEffectWhenCancelledBeforeStartRev
TEST_F(AnimationAnimationPlayerTest, AttachedAnimationPlayers)
{
- RefPtrWillBeRawPtr<Element> element = document->createElement("foo", ASSERT_NO_EXCEPTION);
+ RefPtrWillBePersistent<Element> element = document->createElement("foo", ASSERT_NO_EXCEPTION);
Timing timing;
RefPtrWillBeRawPtr<Animation> animation = Animation::create(element.get(), nullptr, timing);
@@ -705,6 +705,7 @@ TEST_F(AnimationAnimationPlayerTest, AttachedAnimationPlayers)
EXPECT_EQ(1, element->activeAnimations()->players().find(player.get())->value);
player.release();
+ Heap::collectAllGarbage();
EXPECT_TRUE(element->activeAnimations()->players().isEmpty());
}
« no previous file with comments | « no previous file | Source/core/animation/AnimationStackTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698