Omnibox UI Experiments: Add flag to change max autocomplete matches.

Omnibox UI Experiments: Add flag to change max autocomplete matches.

Adds an about:flag to change the maximum number of autocomplete matches
total across all providers.

BUG=720166
Review-Url: https://codereview.chromium.org/2873423002
Cr-Commit-Position: refs/heads/master@{#471855}
Committed: https://chromium.googlesource.com/chromium/src/+/a5a538f9d1c209828582674ff09a11fe12dce47c

[tommycli, 2017-05-10 19:19:00]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 19:20:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 20:35:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 20:35:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2017-05-10 20:43:04]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 20:44:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-05-10 20:48:16]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 20:48:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-05-10 20:49:46]

tommycli@chromium.org changed reviewers:
+ pkasting@chromium.org

[tommycli, 2017-05-10 20:49:47]

pkasting: PTAL again. Screenshots and eng doc in bug.

[commit-bot: I haz the power, 2017-05-10 21:31:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 21:31:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2017-05-10 21:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 21:34:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Kasting, 2017-05-10 22:08:05]

I really would prefer to avoid exposing this user-visibly.  Make it controlled
by a hidden trial, fine, but users twiddling this value the last time we had it
has been a neverending source of whining and complaints in the years since.

I also wrote some on the PRD about why I think experimenting with this value at
all does not make sense as the way to improve quality.

LGTM on the implementation.

https://codereview.chromium.org/2873423002/diff/40001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2873423002/diff/40001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:978:
{OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "12"}};
Why these choices?  There are no odd numbers, for one.  The bounds are a bit
extreme, but OK.

https://codereview.chromium.org/2873423002/diff/40001/components/omnibox/brow...
File components/omnibox/browser/autocomplete_result.cc (right):

https://codereview.chromium.org/2873423002/diff/40001/components/omnibox/brow...
components/omnibox/browser/autocomplete_result.cc:28:
OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, 6);
Nit: For clarity, pull this 6 out as a named constexpr

[tommycli, 2017-05-10 22:41:29]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 22:42:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-05-10 22:44:29]

pkasting: Thanks for the review!

I'll send this into dry run, but I'll engage with you on the PRD along with
Justin before sending it in.

Tommy

https://codereview.chromium.org/2873423002/diff/40001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2873423002/diff/40001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:978:
{OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "12"}};
On 2017/05/10 22:08:05, Peter Kasting wrote:
> Why these choices?  There are no odd numbers, for one.  The bounds are a bit
> extreme, but OK.

Chosen pretty arbitrarily, since we can easily change the choices if these
default ones don't make sense. Happy to consider an alternative set.

https://codereview.chromium.org/2873423002/diff/40001/components/omnibox/brow...
File components/omnibox/browser/autocomplete_result.cc (right):

https://codereview.chromium.org/2873423002/diff/40001/components/omnibox/brow...
components/omnibox/browser/autocomplete_result.cc:28:
OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, 6);
On 2017/05/10 22:08:05, Peter Kasting wrote:
> Nit: For clarity, pull this 6 out as a named constexpr

Done.

[tommycli, 2017-05-10 22:48:06]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 22:49:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 04:52:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:52:09]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tommycli, 2017-05-15 17:33:24]

On 2017/05/10 22:44:29, tommycli wrote:
> pkasting: Thanks for the review!
> 
> I'll send this into dry run, but I'll engage with you on the PRD along with
> Justin before sending it in.
> 
> Tommy
> 
>
https://codereview.chromium.org/2873423002/diff/40001/chrome/browser/about_fl...
> File chrome/browser/about_flags.cc (right):
> 
>
https://codereview.chromium.org/2873423002/diff/40001/chrome/browser/about_fl...
> chrome/browser/about_flags.cc:978:
> {OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "12"}};
> On 2017/05/10 22:08:05, Peter Kasting wrote:
> > Why these choices?  There are no odd numbers, for one.  The bounds are a bit
> > extreme, but OK.
> 
> Chosen pretty arbitrarily, since we can easily change the choices if these
> default ones don't make sense. Happy to consider an alternative set.
> 
>
https://codereview.chromium.org/2873423002/diff/40001/components/omnibox/brow...
> File components/omnibox/browser/autocomplete_result.cc (right):
> 
>
https://codereview.chromium.org/2873423002/diff/40001/components/omnibox/brow...
> components/omnibox/browser/autocomplete_result.cc:28:
> OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, 6);
> On 2017/05/10 22:08:05, Peter Kasting wrote:
> > Nit: For clarity, pull this 6 out as a named constexpr
> 
> Done.

Talked to both Peter and Justin offline -- sending this in as a step toward the
future. -- but we'll move to a more sophisticated model (rather than just
increasing max number of suggestions) at some point.

[tommycli, 2017-05-15 17:33:29]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-05-15 17:33:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2873423002/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2017-05-15 17:34:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 17:40:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 17:40:22]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tommycli, 2017-05-15 17:50:25]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[tommycli, 2017-05-15 17:50:37]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-05-15 17:50:40]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-05-15 17:50:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2873423002/#ps120001
(title: "fix merge'")

[commit-bot: I haz the power, 2017-05-15 17:51:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 19:09:42]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1494870640920320,
"parent_rev": "b5be4e3d0ac15fb087cf1cb63d29d3584ab8a6e9", "commit_rev":
"a5a538f9d1c209828582674ff09a11fe12dce47c"}

[commit-bot: I haz the power, 2017-05-15 19:10:00]

Description was changed from

==========
Omnibox UI Experiments: Add flag to change max autocomplete matches.

Adds an about:flag to change the maximum number of autocomplete matches
total across all providers.

BUG=720166
==========

to

==========
Omnibox UI Experiments: Add flag to change max autocomplete matches.

Adds an about:flag to change the maximum number of autocomplete matches
total across all providers.

BUG=720166

Review-Url: https://codereview.chromium.org/2873423002
Cr-Commit-Position: refs/heads/master@{#471855}
Committed:
https://chromium.googlesource.com/chromium/src/+/a5a538f9d1c209828582674ff09a...
==========

[commit-bot: I haz the power, 2017-05-15 19:10:06]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/a5a538f9d1c209828582674ff09a...

[alexanderbyte23, 2017-06-18 23:01:10]

On 2017/05/10 22:08:05, Peter Kasting wrote:
> I really would prefer to avoid exposing this user-visibly.  Make it controlled
> by a hidden trial, fine, but users twiddling this value the last time we had
it
> has been a neverending source of whining and complaints in the years since.
> 
> I also wrote some on the PRD about why I think experimenting with this value
at
> all does not make sense as the way to improve quality.
> 
> LGTM on the implementation.
> 
>
https://codereview.chromium.org/2873423002/diff/40001/chrome/browser/about_fl...
> File chrome/browser/about_flags.cc (right):
> 
>
https://codereview.chromium.org/2873423002/diff/40001/chrome/browser/about_fl...
> chrome/browser/about_flags.cc:978:
> {OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "12"}};
> Why these choices?  There are no odd numbers, for one.  The bounds are a bit
> extreme, but OK.
> 
>
https://codereview.chromium.org/2873423002/diff/40001/components/omnibox/brow...
> File components/omnibox/browser/autocomplete_result.cc (right):
> 
>
https://codereview.chromium.org/2873423002/diff/40001/components/omnibox/brow...
> components/omnibox/browser/autocomplete_result.cc:28:
> OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, 6);
> Nit: For clarity, pull this 6 out as a named constexpr

Hey Peter, I am out of my league here and just started learning C++ (yay) but I
am content creator who does YouTube and Twitch.tv and adding to this ability to
modify omnibox suggestions to 0 or at least 1 rather than current 4 would be
amazing because I have had times private family facebook urls pop up publicly
because of the "history quick providers" while on stream which is concerning to
me and only way to stop this is deleting browsing history over and over = not a
good workaround or switch to firefox which I hate using. I know I am a really
random minority but feature like this would mean lot to people who have to
record/stream their screen and do not want URLs showing up when typing in the
omnibox that could be used as attack method for trolls or hackers. Sorry if I
posted this in wrong area.

[Peter Kasting, 2017-06-19 00:51:45]

On 2017/06/18 23:01:10, alexanderbyte23 wrote:
> Hey Peter, I am out of my league here and just started learning C++ (yay) but
I
> am content creator who does YouTube and Twitch.tv and adding to this ability
to
> modify omnibox suggestions to 0 or at least 1 rather than current 4 would be
> amazing because I have had times private family facebook urls pop up publicly
> because of the "history quick providers" while on stream which is concerning
to
> me and only way to stop this is deleting browsing history over and over = not
a
> good workaround or switch to firefox which I hate using. I know I am a really
> random minority but feature like this would mean lot to people who have to
> record/stream their screen and do not want URLs showing up when typing in the
> omnibox that could be used as attack method for trolls or hackers. Sorry if I
> posted this in wrong area.

You did, but I will try to be helpful :)

This is what Chrome multiprofile support is designed for.  Use one Chrome
profile only when you're streaming, use a different profile to do all your other
stuff.  It's easy to open links from one profile into the other by either
dragging them between windows & dropping on the tabstrip, or using context menu
options on the link to open in the other profile.

I use this same technique to separate work and personal stuff, for example. 
This also ensures the suggestions you get in each profile are tuned to the
activities you do in that profile, which improves their quality.