Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2873423002: Omnibox UI Experiments: Add flag to change max autocomplete matches. (Closed)
Patch Set: fix merge' Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 948 matching lines...) Expand 10 before | Expand all | Expand 10 after
959 const FeatureEntry::Choice kEnableHeapProfilingChoices[] = { 959 const FeatureEntry::Choice kEnableHeapProfilingChoices[] = {
960 {flags_ui::kGenericExperimentChoiceDisabled, "", ""}, 960 {flags_ui::kGenericExperimentChoiceDisabled, "", ""},
961 {flag_descriptions::kEnableHeapProfilingModePseudo, 961 {flag_descriptions::kEnableHeapProfilingModePseudo,
962 switches::kEnableHeapProfiling, switches::kEnableHeapProfilingModePseudo}, 962 switches::kEnableHeapProfiling, switches::kEnableHeapProfilingModePseudo},
963 {flag_descriptions::kEnableHeapProfilingModeNative, 963 {flag_descriptions::kEnableHeapProfilingModeNative,
964 switches::kEnableHeapProfiling, switches::kEnableHeapProfilingModeNative}, 964 switches::kEnableHeapProfiling, switches::kEnableHeapProfilingModeNative},
965 {flag_descriptions::kEnableHeapProfilingTaskProfiler, 965 {flag_descriptions::kEnableHeapProfilingTaskProfiler,
966 switches::kEnableHeapProfiling, 966 switches::kEnableHeapProfiling,
967 switches::kEnableHeapProfilingTaskProfiler}}; 967 switches::kEnableHeapProfilingTaskProfiler}};
968 968
969 const FeatureEntry::FeatureParam kOmniboxUIMaxAutocompleteMatches4[] = {
970 {OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "4"}};
971 const FeatureEntry::FeatureParam kOmniboxUIMaxAutocompleteMatches6[] = {
972 {OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "6"}};
973 const FeatureEntry::FeatureParam kOmniboxUIMaxAutocompleteMatches8[] = {
974 {OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "8"}};
975 const FeatureEntry::FeatureParam kOmniboxUIMaxAutocompleteMatches10[] = {
976 {OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "10"}};
977 const FeatureEntry::FeatureParam kOmniboxUIMaxAutocompleteMatches12[] = {
978 {OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "12"}};
979
980 const FeatureEntry::FeatureVariation
981 kOmniboxUIMaxAutocompleteMatchesVariations[] = {
982 {"4 matches", kOmniboxUIMaxAutocompleteMatches4,
983 arraysize(kOmniboxUIMaxAutocompleteMatches4), nullptr},
984 {"6 matches", kOmniboxUIMaxAutocompleteMatches6,
985 arraysize(kOmniboxUIMaxAutocompleteMatches6), nullptr},
986 {"8 matches", kOmniboxUIMaxAutocompleteMatches8,
987 arraysize(kOmniboxUIMaxAutocompleteMatches8), nullptr},
988 {"10 matches", kOmniboxUIMaxAutocompleteMatches10,
989 arraysize(kOmniboxUIMaxAutocompleteMatches10), nullptr},
990 {"12 matches", kOmniboxUIMaxAutocompleteMatches12,
991 arraysize(kOmniboxUIMaxAutocompleteMatches12), nullptr}};
992
969 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin4px[] = { 993 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin4px[] = {
970 {OmniboxFieldTrial::kUIVerticalMarginParam, "4"}}; 994 {OmniboxFieldTrial::kUIVerticalMarginParam, "4"}};
971 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin8px[] = { 995 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin8px[] = {
972 {OmniboxFieldTrial::kUIVerticalMarginParam, "8"}}; 996 {OmniboxFieldTrial::kUIVerticalMarginParam, "8"}};
973 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin12px[] = { 997 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin12px[] = {
974 {OmniboxFieldTrial::kUIVerticalMarginParam, "12"}}; 998 {OmniboxFieldTrial::kUIVerticalMarginParam, "12"}};
975 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin16px[] = { 999 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin16px[] = {
976 {OmniboxFieldTrial::kUIVerticalMarginParam, "16"}}; 1000 {OmniboxFieldTrial::kUIVerticalMarginParam, "16"}};
977 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin20px[] = { 1001 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin20px[] = {
978 {OmniboxFieldTrial::kUIVerticalMarginParam, "20"}}; 1002 {OmniboxFieldTrial::kUIVerticalMarginParam, "20"}};
(...skipping 1878 matching lines...) Expand 10 before | Expand all | Expand 10 after
2857 {"enable-heap-profiling", flag_descriptions::kEnableHeapProfilingName, 2881 {"enable-heap-profiling", flag_descriptions::kEnableHeapProfilingName,
2858 flag_descriptions::kEnableHeapProfilingDescription, kOsAll, 2882 flag_descriptions::kEnableHeapProfilingDescription, kOsAll,
2859 MULTI_VALUE_TYPE(kEnableHeapProfilingChoices)}, 2883 MULTI_VALUE_TYPE(kEnableHeapProfilingChoices)},
2860 2884
2861 #if defined(TOOLKIT_VIEWS) || (defined(OS_MACOSX) && !defined(OS_IOS)) 2885 #if defined(TOOLKIT_VIEWS) || (defined(OS_MACOSX) && !defined(OS_IOS))
2862 {"show-cert-link", flag_descriptions::kShowCertLinkOnPageInfoName, 2886 {"show-cert-link", flag_descriptions::kShowCertLinkOnPageInfoName,
2863 flag_descriptions::kShowCertLinkOnPageInfoDescription, kOsDesktop, 2887 flag_descriptions::kShowCertLinkOnPageInfoDescription, kOsDesktop,
2864 SINGLE_VALUE_TYPE(switches::kShowCertLink)}, 2888 SINGLE_VALUE_TYPE(switches::kShowCertLink)},
2865 #endif 2889 #endif
2866 2890
2891 {"omnibox-ui-max-autocomplete-matches",
2892 flag_descriptions::kOmniboxUIMaxAutocompleteMatchesName,
2893 flag_descriptions::kOmniboxUIMaxAutocompleteMatchesDescription, kOsDesktop,
2894 FEATURE_WITH_PARAMS_VALUE_TYPE(
2895 omnibox::kUIExperimentMaxAutocompleteMatches,
2896 kOmniboxUIMaxAutocompleteMatchesVariations,
2897 "OmniboxUIMaxAutocompleteVariations")},
2898
2867 {"omnibox-ui-vertical-margin", 2899 {"omnibox-ui-vertical-margin",
2868 flag_descriptions::kOmniboxUIVerticalMarginName, 2900 flag_descriptions::kOmniboxUIVerticalMarginName,
2869 flag_descriptions::kOmniboxUIVerticalMarginDescription, kOsDesktop, 2901 flag_descriptions::kOmniboxUIVerticalMarginDescription, kOsDesktop,
2870 FEATURE_WITH_PARAMS_VALUE_TYPE(omnibox::kUIExperimentVerticalMargin, 2902 FEATURE_WITH_PARAMS_VALUE_TYPE(omnibox::kUIExperimentVerticalMargin,
2871 kOmniboxUIVerticalMarginVariations, 2903 kOmniboxUIVerticalMarginVariations,
2872 "OmniboxUIVerticalMarginVariations")}, 2904 "OmniboxUIVerticalMarginVariations")},
2873 2905
2874 {"use-suggestions-even-if-few", 2906 {"use-suggestions-even-if-few",
2875 flag_descriptions::kUseSuggestionsEvenIfFewFeatureName, 2907 flag_descriptions::kUseSuggestionsEvenIfFewFeatureName,
2876 flag_descriptions::kUseSuggestionsEvenIfFewFeatureDescription, kOsAll, 2908 flag_descriptions::kUseSuggestionsEvenIfFewFeatureDescription, kOsAll,
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
3126 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3158 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3127 3159
3128 const FeatureEntry* GetFeatureEntries(size_t* count) { 3160 const FeatureEntry* GetFeatureEntries(size_t* count) {
3129 *count = arraysize(kFeatureEntries); 3161 *count = arraysize(kFeatureEntries);
3130 return kFeatureEntries; 3162 return kFeatureEntries;
3131 } 3163 }
3132 3164
3133 } // namespace testing 3165 } // namespace testing
3134 3166
3135 } // namespace about_flags 3167 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698