📰 Appropriately mark actions not user triggered

[Suggestions] Appropriately mark actions not user triggered

Follow up to https://crrev.com/f6500c14fa6592426db531673f484877cacdd651

BUG=693593

[dgn, 2017-05-10 17:25:07]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[dgn, 2017-05-10 17:25:27]

dgn@chromium.org changed reviewers:
+ asvitkine@chromium.org, bauerb@chromium.org

[dgn, 2017-05-10 17:25:27]

PTAL

[commit-bot: I haz the power, 2017-05-10 17:26:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2017-05-10 17:26:55]

note: I didn't touch preexisting actions

A breakdown of our user actions is available at
https://docs.google.com/spreadsheets/d/1I5-p_WCQJxVv-OK3BXyGQ9McjGsUOvr7Er454...

[commit-bot: I haz the power, 2017-05-10 17:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 17:41:48]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-05-11 08:47:01]

https://codereview.chromium.org/2873373002/diff/1/tools/metrics/actions/actio...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2873373002/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:15926: <action
name="Suggestions.Category.Dismissed" not_user_triggered="true">
Given the description this seems a bit strange :) Maybe explain why this is not
considered user-triggered?

[dgn, 2017-05-11 10:37:36]

https://codereview.chromium.org/2873373002/diff/1/tools/metrics/actions/actio...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2873373002/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:15926: <action
name="Suggestions.Category.Dismissed" not_user_triggered="true">
On 2017/05/11 08:47:01, Bernhard Bauer wrote:
> Given the description this seems a bit strange :) Maybe explain why this is
not
> considered user-triggered? 

Hum yes agreed. The user-triggered action is "dismiss a card" or "hit remove in
the context menu", which causes dismissing a category, a content suggestion or a
site suggestion. Would changing the description for something like "A suggestion
category was dismissed" be enough?

[Bernhard Bauer, 2017-05-11 13:24:51]

https://codereview.chromium.org/2873373002/diff/1/tools/metrics/actions/actio...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2873373002/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:15926: <action
name="Suggestions.Category.Dismissed" not_user_triggered="true">
On 2017/05/11 10:37:36, dgn wrote:
> On 2017/05/11 08:47:01, Bernhard Bauer wrote:
> > Given the description this seems a bit strange :) Maybe explain why this is
> not
> > considered user-triggered? 
> 
> Hum yes agreed. The user-triggered action is "dismiss a card" or "hit remove
in
> the context menu", which causes dismissing a category, a content suggestion or
a
> site suggestion. Would changing the description for something like "A
suggestion
> category was dismissed" be enough?

I would maybe add an explicit additional sentence that this is the result of a
user action that is already separately recorded and marked as user-triggered
there. Description characters are cheap :)

[dgn, 2017-05-11 15:10:35]

PTAL

[Bernhard Bauer, 2017-05-11 15:13:50]

lgtm

[Alexei Svitkine (slow), 2017-05-12 21:10:45]

lgtm