Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2064)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarCollection.java

Issue 2873373002: 📰 Appropriately mark actions not user triggered
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarCollection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarCollection.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarCollection.java
index e8b2965e4e6e4c10e4810b52a1734b59a1245c50..f87bdd2e5f5c3ddcd72912485c5b2544c04133e9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarCollection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarCollection.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.snackbar;
+import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
import java.util.Deque;
@@ -45,8 +46,12 @@ private Snackbar removeCurrent(boolean isAction) {
Snackbar current = mSnackbars.pollFirst();
if (current != null) {
SnackbarController controller = current.getController();
- if (isAction) controller.onAction(current.getActionData());
- else controller.onDismissNoAction(current.getActionData());
+ if (isAction) {
+ RecordUserAction.record("Snackbar.ButtonTapped");
+ controller.onAction(current.getActionData());
+ } else {
+ controller.onDismissNoAction(current.getActionData());
+ }
}
return current;
}
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698