Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: tools/metrics/actions/actions.xml

Issue 2873373002: 📰 Appropriately mark actions not user triggered
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarCollection.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index ae4e8be02c16ef4a0920f2b417c5d874b5a24cdf..bca8cb843d35519f1fa025412b7e8d9a98e8d5ce 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -15311,6 +15311,13 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
+<action name="Snackbar.ButtonTapped">
+ <owner>dgn@chromium.org</owner>
+ <description>
+ The user tapped on the snackbar button before it disappeared.
+ </description>
+</action>
+
<action name="StackedTab_DragActiveTab">
<owner>bruthig@chromium.org</owner>
<owner>tdanderson@chromium.org</owner>
@@ -15923,36 +15930,49 @@ should be able to be added at any place in this file.
</description>
</action>
-<action name="Suggestions.Category.Dismissed">
+<action name="Suggestions.Category.Dismissed" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
- <description>User dismissed a content suggestions category.</description>
+ <description>
+ User dismissed a content suggestions category as the result of an action
+ that is already separately recorded as user-triggered.
+ </description>
</action>
-<action name="Suggestions.Category.Fetch">
+<action name="Suggestions.Category.Fetch" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
- <description>User requested fetching more content suggestions.</description>
+ <description>
+ User requested fetching more content suggestions as the result of an action
+ that is already separately recorded as user-triggered.
+ </description>
</action>
-<action name="Suggestions.Category.ViewAll">
+<action name="Suggestions.Category.ViewAll" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
<description>
- User navigated to the complete view of a content suggestions section.
+ User navigated to the complete view of a content suggestions section as the
+ result of an action that is already separately recorded as user-triggered.
</description>
</action>
-<action name="Suggestions.Content.Dismissed">
+<action name="Suggestions.Content.Dismissed" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
- <description>User dismissed a content suggestion.</description>
+ <description>
+ User dismissed a content suggestion as the result of an action that is
+ already separately recorded as user-triggered.
+ </description>
</action>
-<action name="Suggestions.Content.Opened">
+<action name="Suggestions.Content.Opened" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
- <description>User opened a content suggestion.</description>
+ <description>
+ User opened a content suggestion as the result of an action that is already
+ separately recorded as user-triggered.
+ </description>
</action>
<action name="Suggestions.ContextMenu.DownloadItem">
@@ -16005,28 +16025,40 @@ should be able to be added at any place in this file.
</description>
</action>
-<action name="Suggestions.Site.RemovalUndone">
+<action name="Suggestions.Site.RemovalUndone" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
- <description>User reverted the removal of a suggested site.</description>
+ <description>
+ User reverted the removal of a suggested site as the result of an action
+ that is already separately recorded as user-triggered.
+ </description>
</action>
-<action name="Suggestions.Site.Removed">
+<action name="Suggestions.Site.Removed" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
- <description>User removed a suggested site.</description>
+ <description>
+ User removed a suggested site as the result of an action that is already
+ separately recorded as user-triggered.
+ </description>
</action>
-<action name="Suggestions.SurfaceHidden">
+<action name="Suggestions.SurfaceHidden" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
- <description>User closed the content suggestions UI.</description>
+ <description>
+ The content suggestions UI got hidden as the result of a user action that is
+ already separately recorded as user-triggered.
+ </description>
</action>
-<action name="Suggestions.SurfaceVisible">
+<action name="Suggestions.SurfaceVisible" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
- <description>User opened the content suggestions UI.</description>
+ <description>
+ The content suggestions UI got shown as the result of a user action that is
+ already separately recorded as user-triggered.
+ </description>
</action>
<action name="Suggestions.Tile.RemovalUndone">
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarCollection.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698