mac color: Use sRGB for native controls instead of device RGB

mac color: Use sRGB for native controls instead of device RGB

Native controls are interpreted as being in sRGB color by Skia. Ensure
that the color values that we produce are sRGB color values when color
correct rendering is enabled.

The conversion to device color space will be done at raster or composite
time (depending on various factors).

BUG=713891
Review-Url: https://codereview.chromium.org/2873333002
Cr-Commit-Position: refs/heads/master@{#471937}
Committed: https://chromium.googlesource.com/chromium/src/+/6fb77648845ad5dee4e264afa83d2cc6d96a2fa8

[ccameron, 2017-05-10 15:36:18]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 15:37:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-05-10 16:13:01]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 16:14:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 17:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 17:35:05]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ccameron, 2017-05-11 08:53:28]

ccameron@chromium.org changed reviewers:
+ thakis@chromium.org

[ccameron, 2017-05-11 08:53:28]

This whole "be conscious about what color space we're using in Cocoa" thing
needs to be done across most of the Cocoa code out there as well.

This just makes WebKit stop using non-sRGB color space.

[ccameron, 2017-05-15 20:41:34]

ping

[Nico, 2017-05-15 20:51:24]

lgtm

What's the testing plan for this? It seems like we'll need these toggles in many
places, how do we make sure we insert them everywhere we need them, and that we
don't regress once we've inserted them?

[ccameron, 2017-05-15 21:02:48]

On 2017/05/15 20:51:24, Nico wrote:
> lgtm
> 
> What's the testing plan for this?
> and that we don't regress once we've inserted them?

I'm moving all layout tests to use color correct rendering, and these paths are
extensively tested by layout tests.

> It seems like we'll need these toggles in many places, how do we make sure we
insert them
> everywhere we need them

Right now I'm searching the codebase for all problematic functions ("device
color space", "generic rgb color space", etc). These were the only instances
that I found in third_party/WebKit that are Mac-specific (there's still the
concerning issue of third_party/WebKit/Source/platform/graphics/ColorSpace.cpp
which need some attention as well).

[ccameron, 2017-05-15 21:02:53]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-05-15 21:03:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 22:56:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494882173146110,
"parent_rev": "f8c4033754c54add7fbc1ce521116d88cda5c410", "commit_rev":
"6fb77648845ad5dee4e264afa83d2cc6d96a2fa8"}

[commit-bot: I haz the power, 2017-05-15 22:57:07]

Description was changed from

==========
mac color: Use sRGB for native controls instead of device RGB

Native controls are interpreted as being in sRGB color by Skia. Ensure
that the color values that we produce are sRGB color values when color
correct rendering is enabled.

The conversion to device color space will be done at raster or composite
time (depending on various factors).

BUG=713891
==========

to

==========
mac color: Use sRGB for native controls instead of device RGB

Native controls are interpreted as being in sRGB color by Skia. Ensure
that the color values that we produce are sRGB color values when color
correct rendering is enabled.

The conversion to device color space will be done at raster or composite
time (depending on various factors).

BUG=713891

Review-Url: https://codereview.chromium.org/2873333002
Cr-Commit-Position: refs/heads/master@{#471937}
Committed:
https://chromium.googlesource.com/chromium/src/+/6fb77648845ad5dee4e264afa83d...
==========

[commit-bot: I haz the power, 2017-05-15 22:57:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6fb77648845ad5dee4e264afa83d...