mac color: Use sRGB for native controls instead of device RGB

third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

 /*
  * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Google, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #import "core/layout/LayoutThemeMac.h"
 
+#import <AvailabilityMacros.h>
+#import <Carbon/Carbon.h>
+#import <Cocoa/Cocoa.h>
+#import <math.h>
 #import "core/CSSValueKeywords.h"
 #import "core/HTMLNames.h"
 #import "core/fileapi/FileList.h"
 #import "core/layout/LayoutProgress.h"
 #import "core/layout/LayoutView.h"
 #import "core/paint/MediaControlsPainter.h"
 #import "core/style/ShadowList.h"
 #import "platform/LayoutTestSupport.h"
 #import "platform/PlatformResourceLoader.h"
+#import "platform/RuntimeEnabledFeatures.h"
 #import "platform/Theme.h"
 #import "platform/graphics/BitmapImage.h"
 #import "platform/mac/ColorMac.h"
 #import "platform/mac/ThemeMac.h"
 #import "platform/mac/VersionUtilMac.h"
 #import "platform/mac/WebCoreNSCellExtras.h"
 #import "platform/text/PlatformLocale.h"
 #import "platform/text/StringTruncator.h"
-#import <AvailabilityMacros.h>
-#import <Carbon/Carbon.h>
-#import <Cocoa/Cocoa.h>
-#import <math.h>
 
 // The methods in this file are specific to the Mac OS X platform.
 
 @interface BlinkLayoutThemeNotificationObserver : NSObject {
   blink::LayoutTheme* _theme;
 }
 
 - (id)initWithTheme:(blink::LayoutTheme*)theme;
 - (void)systemColorsDidChange:(NSNotification*)notification;
 
@@ skipping 67 matching lines @@
   int font_size = style.FontSize();
   if (font_size == [NSFont systemFontSizeForControlSize:NSRegularControlSize])
     return true;
   if (font_size == [NSFont systemFontSizeForControlSize:NSSmallControlSize])
     return true;
   if (font_size == [NSFont systemFontSizeForControlSize:NSMiniControlSize])
     return true;
   return false;
 }
 
+NSColor* ColorInColorSpace(NSColor* color) {
+  if (RuntimeEnabledFeatures::colorCorrectRenderingEnabled()) {
+    return [color colorUsingColorSpace:[NSColorSpace sRGBColorSpace]];
+  } else {
+    return [color colorUsingColorSpaceName:NSDeviceRGBColorSpace];
+  }
+}
+
 }  // namespace
 
 using namespace HTMLNames;
 
 LayoutThemeMac::LayoutThemeMac()
     : LayoutTheme(PlatformTheme()),
       notification_observer_(
           kAdoptNS,
           [[BlinkLayoutThemeNotificationObserver alloc] initWithTheme:this]),
       painter_(*this) {
   [[NSNotificationCenter defaultCenter]
       addObserver:notification_observer_.Get()
          selector:@selector(systemColorsDidChange:)
              name:NSSystemColorsDidChangeNotification
            object:nil];
 }
 
 LayoutThemeMac::~LayoutThemeMac() {
   [[NSNotificationCenter defaultCenter]
       removeObserver:notification_observer_.Get()];
 }
 
 Color LayoutThemeMac::PlatformActiveSelectionBackgroundColor() const {
-  NSColor* color = [[NSColor selectedTextBackgroundColor]
-      colorUsingColorSpaceName:NSDeviceRGBColorSpace];
+  NSColor* color = ColorInColorSpace([NSColor selectedTextBackgroundColor]);
   return Color(static_cast<int>(255.0 * [color redComponent]),
                static_cast<int>(255.0 * [color greenComponent]),
                static_cast<int>(255.0 * [color blueComponent]));
 }
 
 Color LayoutThemeMac::PlatformInactiveSelectionBackgroundColor() const {
-  NSColor* color = [[NSColor secondarySelectedControlColor]
-      colorUsingColorSpaceName:NSDeviceRGBColorSpace];
+  NSColor* color = ColorInColorSpace([NSColor secondarySelectedControlColor]);
   return Color(static_cast<int>(255.0 * [color redComponent]),
                static_cast<int>(255.0 * [color greenComponent]),
                static_cast<int>(255.0 * [color blueComponent]));
 }
 
 Color LayoutThemeMac::PlatformActiveSelectionForegroundColor() const {
   return Color::kBlack;
 }
 
 Color LayoutThemeMac::PlatformActiveListBoxSelectionBackgroundColor() const {
-  NSColor* color = [[NSColor alternateSelectedControlColor]
-      colorUsingColorSpaceName:NSDeviceRGBColorSpace];
+  NSColor* color = ColorInColorSpace([NSColor alternateSelectedControlColor]);
   return Color(static_cast<int>(255.0 * [color redComponent]),
                static_cast<int>(255.0 * [color greenComponent]),
                static_cast<int>(255.0 * [color blueComponent]));
 }
 
 Color LayoutThemeMac::PlatformActiveListBoxSelectionForegroundColor() const {
   return Color::kWhite;
 }
 
 Color LayoutThemeMac::PlatformInactiveListBoxSelectionForegroundColor() const {
@@ skipping 70 matching lines @@
 }
 
 bool LayoutThemeMac::NeedsHackForTextControlWithFontFamily(
     const AtomicString& family) const {
   // This hack is only applied on OSX 10.9.
   // https://code.google.com/p/chromium/issues/detail?id=515989#c8
   return IsOS10_9() && family == FontFamilyNames::system_ui;
 }
 
 static RGBA32 ConvertNSColorToColor(NSColor* color) {
-  NSColor* color_in_color_space =
-      [color colorUsingColorSpaceName:NSDeviceRGBColorSpace];
+  NSColor* color_in_color_space = ColorInColorSpace(color);
   if (color_in_color_space) {
     static const double kScaleFactor = nextafter(256.0, 0.0);
     return MakeRGB(
         static_cast<int>(kScaleFactor * [color_in_color_space redComponent]),
         static_cast<int>(kScaleFactor * [color_in_color_space greenComponent]),
         static_cast<int>(kScaleFactor * [color_in_color_space blueComponent]));
   }
 
   // This conversion above can fail if the NSColor in question is an
-  // NSPatternColor
-  // (as many system colors are). These colors are actually a repeating pattern
-  // not just a solid color. To work around this we simply draw a 1x1 image of
-  // the color and use that pixel's color. It might be better to use an average
-  // of
-  // the colors in the pattern instead.
+  // NSPatternColor (as many system colors are). These colors are actually a
+  // repeating pattern not just a solid color. To work around this we simply
+  // draw a 1x1 image of the color and use that pixel's color. It might be
+  // better to use an average of the colors in the pattern instead.
   NSBitmapImageRep* offscreen_rep =
       [[NSBitmapImageRep alloc] initWithBitmapDataPlanes:nil
                                               pixelsWide:1
                                               pixelsHigh:1
                                            bitsPerSample:8
                                          samplesPerPixel:4
                                                 hasAlpha:YES
                                                 isPlanar:NO
                                           colorSpaceName:NSDeviceRGBColorSpace
                                              bytesPerRow:4
                                             bitsPerPixel:32];
 
   [NSGraphicsContext saveGraphicsState];
   [NSGraphicsContext
       setCurrentContext:[NSGraphicsContext
                             graphicsContextWithBitmapImageRep:offscreen_rep]];
   NSEraseRect(NSMakeRect(0, 0, 1, 1));
   [color drawSwatchInRect:NSMakeRect(0, 0, 1, 1)];
   [NSGraphicsContext restoreGraphicsState];
 
   NSUInteger pixel[4];
   [offscreen_rep getPixel:pixel atX:0 y:0];
-
   [offscreen_rep release];
-
-  return MakeRGB(pixel[0], pixel[1], pixel[2]);
+  // This recursive call will not recurse again, because the color space
+  // the second time around is NSDeviceRGBColorSpace.
+  return ConvertNSColorToColor([NSColor colorWithDeviceRed:pixel[0] / 255.
+                                                     green:pixel[1] / 255.
+                                                      blue:pixel[2] / 255.
+                                                     alpha:1.]);
 }
 
 static RGBA32 MenuBackgroundColor() {
   NSBitmapImageRep* offscreen_rep =
       [[NSBitmapImageRep alloc] initWithBitmapDataPlanes:nil
                                               pixelsWide:1
                                               pixelsHigh:1
                                            bitsPerSample:8
                                          samplesPerPixel:4
                                                 hasAlpha:YES
                                                 isPlanar:NO
                                           colorSpaceName:NSDeviceRGBColorSpace
                                              bytesPerRow:4
                                             bitsPerPixel:32];
 
   CGContextRef context = static_cast<CGContextRef>([[NSGraphicsContext
       graphicsContextWithBitmapImageRep:offscreen_rep] graphicsPort]);
   CGRect rect = CGRectMake(0, 0, 1, 1);
   HIThemeMenuDrawInfo draw_info;
   draw_info.version = 0;
   draw_info.menuType = kThemeMenuTypePopUp;
   HIThemeDrawMenuBackground(&rect, &draw_info, context,
                             kHIThemeOrientationInverted);
 
   NSUInteger pixel[4];
   [offscreen_rep getPixel:pixel atX:0 y:0];
-
   [offscreen_rep release];
-
-  return MakeRGB(pixel[0], pixel[1], pixel[2]);
+  return ConvertNSColorToColor([NSColor colorWithDeviceRed:pixel[0] / 255.
+                                                     green:pixel[1] / 255.
+                                                      blue:pixel[2] / 255.
+                                                     alpha:1.]);
 }
 
 void LayoutThemeMac::PlatformColorsDidChange() {
   system_color_cache_.clear();
   LayoutTheme::PlatformColorsDidChange();
 }
 
 Color LayoutThemeMac::SystemColor(CSSValueID css_value_id) const {
   {
     HashMap<int, RGBA32>::iterator it = system_color_cache_.find(css_value_id);
@@ skipping 759 matching lines @@
 }
 
 bool LayoutThemeMac::ShouldUseFallbackTheme(const ComputedStyle& style) const {
   ControlPart part = style.Appearance();
   if (part == kCheckboxPart || part == kRadioPart)
     return style.EffectiveZoom() != 1;
   return false;
 }
 
 }  // namespace blink