Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2873243003: Attempt to move USING_SYSTEM_ICU version of TextCodecICU to new blink style. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to move USING_SYSTEM_ICU version of TextCodecICU to new blink style. No intended behavior change. BUG=TextCodecICU Review-Url: https://codereview.chromium.org/2873243003 Cr-Commit-Position: refs/heads/master@{#470940} Committed: https://chromium.googlesource.com/chromium/src/+/2598ba647d0e3d19bd03092d92edeb2d7816566b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -77 lines) Patch
M third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h View 2 chunks +2 lines, -8 lines 1 comment Download
M third_party/WebKit/Source/platform/wtf/text/TextCodecICU.cpp View 9 chunks +65 lines, -69 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Nico
https://codereview.chromium.org/2873243003/diff/1/third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h File third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h (left): https://codereview.chromium.org/2873243003/diff/1/third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h#oldcode73 third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h:73: #endif Nothing calls these.
3 years, 7 months ago (2017-05-10 18:14:01 UTC) #3
jungshik at Google
LGTM (two red bots are just flaky, I guess).
3 years, 7 months ago (2017-05-11 06:28:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873243003/1
3 years, 7 months ago (2017-05-11 12:02:45 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 13:24:32 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2598ba647d0e3d19bd03092d92ed...

Powered by Google App Engine
This is Rietveld 408576698