Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h

Issue 2873243003: Attempt to move USING_SYSTEM_ICU version of TextCodecICU to new blink style. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/wtf/text/TextCodecICU.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h
diff --git a/third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h b/third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h
index 83f4ac0af355a38f0e423883fa42f962d2276317..f983a9a5be0d52af2b55111f073e4d2c42e6836b 100644
--- a/third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h
+++ b/third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h
@@ -65,12 +65,6 @@ class TextCodecICU final : public TextCodec {
void CreateICUConverter() const;
void ReleaseICUConverter() const;
-#if defined(USING_SYSTEM_ICU)
- bool needsGBKFallbacks() const { return m_needsGBKFallbacks; }
- void setNeedsGBKFallbacks(bool needsFallbacks) {
- m_needsGBKFallbacks = needsFallbacks;
- }
-#endif
Nico 2017/05/10 18:14:01 Nothing calls these.
int DecodeToBuffer(UChar* buffer,
UChar* buffer_limit,
@@ -81,9 +75,9 @@ class TextCodecICU final : public TextCodec {
UErrorCode&);
TextEncoding encoding_;
- mutable UConverter* converter_icu_;
+ mutable UConverter* converter_icu_ = nullptr;
#if defined(USING_SYSTEM_ICU)
- mutable bool m_needsGBKFallbacks;
+ mutable bool needs_gbk_fallbacks_ = false;
#endif
FRIEND_TEST_ALL_PREFIXES(TextCodecICUTest, IgnorableCodePoint);
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/wtf/text/TextCodecICU.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698