Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2873153005: Revert of Update ozone/drm proxy_helpers.h to support move-only types. (Closed)

Created:
3 years, 7 months ago by James Cook
Modified:
3 years, 7 months ago
Reviewers:
rjkroege, dnicoara
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update ozone/drm proxy_helpers.h to support move-only types. (patchset #1 id:1 of https://codereview.chromium.org/2873963004/ ) Reason for revert: ozone_unittests has been failing continuously since this landed: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/46812 [ RUN ] ProxyHelpersTest.PostTask ../../ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc:69: Failure Value of: main_checker_.CalledOnValidThread() Actual: true Expected: false ../../ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc:50: Failure Value of: main_checker_.CalledOnValidThread() Actual: true Expected: false ../../ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc:75: Failure Value of: drm_checker_.CalledOnValidThread() Actual: true Expected: false Original issue's description: > Update ozone/drm proxy_helpers.h to support move-only types. > > As a helpful prerequisite for the use of mojo IPC in ozone/drm, > support move only types in proxy_helpers.h callback sequences. > > BUG=620927 > > Review-Url: https://codereview.chromium.org/2873963004 > Cr-Commit-Position: refs/heads/master@{#470715} > Committed: https://chromium.googlesource.com/chromium/src/+/a82a006f8420ecc7c75deab4f1e9d23c43616e1f TBR=dnicoara@chromium.org,rjkroege@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=620927 Review-Url: https://codereview.chromium.org/2873153005 Cr-Commit-Position: refs/heads/master@{#471033} Committed: https://chromium.googlesource.com/chromium/src/+/29a9efd8a6d120ebb9752d4e9166fc9447df4789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -189 lines) Patch
M ui/ozone/platform/drm/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/proxy_helpers.h View 2 chunks +0 lines, -20 lines 0 comments Download
D ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc View 1 chunk +0 lines, -168 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
James Cook
Created Revert of Update ozone/drm proxy_helpers.h to support move-only types.
3 years, 7 months ago (2017-05-11 19:08:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873153005/1
3 years, 7 months ago (2017-05-11 19:09:39 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 19:12:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29a9efd8a6d120ebb9752d4e9166...

Powered by Google App Engine
This is Rietveld 408576698