Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2873963004: Update ozone/drm proxy_helpers.h to support move-only types. (Closed)

Created:
3 years, 7 months ago by rjkroege
Modified:
3 years, 7 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ozone/drm proxy_helpers.h to support move-only types. As a helpful prerequisite for the use of mojo IPC in ozone/drm, support move only types in proxy_helpers.h callback sequences. BUG=620927 Review-Url: https://codereview.chromium.org/2873963004 Cr-Original-Commit-Position: refs/heads/master@{#470715} Committed: https://chromium.googlesource.com/chromium/src/+/a82a006f8420ecc7c75deab4f1e9d23c43616e1f Review-Url: https://codereview.chromium.org/2873963004 Cr-Commit-Position: refs/heads/master@{#471486} Committed: https://chromium.googlesource.com/chromium/src/+/2ae4e4bee29bcb52bc0dd21a2dd59551003cd678

Patch Set 1 #

Patch Set 2 : fix test to run with dcheck_always_on = false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -0 lines) Patch
M ui/ozone/platform/drm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/proxy_helpers.h View 2 chunks +20 lines, -0 lines 0 comments Download
A ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc View 1 1 chunk +159 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
rjkroege
ptal
3 years, 7 months ago (2017-05-10 18:11:59 UTC) #2
dnicoara
lgtm
3 years, 7 months ago (2017-05-10 18:59:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873963004/1
3 years, 7 months ago (2017-05-10 19:35:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a82a006f8420ecc7c75deab4f1e9d23c43616e1f
3 years, 7 months ago (2017-05-10 21:25:13 UTC) #8
James Cook
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2873153005/ by jamescook@chromium.org. ...
3 years, 7 months ago (2017-05-11 19:08:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873963004/20001
3 years, 7 months ago (2017-05-12 19:24:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/369627)
3 years, 7 months ago (2017-05-12 19:59:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873963004/20001
3 years, 7 months ago (2017-05-12 21:45:58 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 23:30:26 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2ae4e4bee29bcb52bc0dd21a2dd5...

Powered by Google App Engine
This is Rietveld 408576698