Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2873153002:
DevTools: Draw screenshot independently of frames bar on flamechart. (Closed)
|
Created:
3 years, 7 months ago by alph Modified:
3 years, 7 months ago Reviewers:
caseq CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Draw screenshot independently of frames bar on flamechart.
BUG=705054
Review-Url: https://codereview.chromium.org/2873153002
Cr-Commit-Position: refs/heads/master@{#471237}
Committed: https://chromium.googlesource.com/chromium/src/+/df53c315ea874b85d78d91b95443a9461c59d225
Patch Set 1 #
Total comments: 10
Patch Set 2 : addressing nits #
Messages
Total messages: 26 (13 generated)
alph@chromium.org changed reviewers: + caseq@chromium.org
lgtm https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js (right): https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:105: if (entryType === Timeline.TimelineFlameChartDataProvider.EntryType.Event) { nit: consider aliasing EntryType to something. https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:470: this._model.maximumRecordTime() - screenshots.peekLast().timestamp; just use prevTimestamp? https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:547: if (type === Timeline.TimelineFlameChartDataProvider.EntryType.Event) { nit: consider aliasing EntryType to something. https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:652: if (type === Timeline.TimelineFlameChartDataProvider.EntryType.Frame) { ditto. https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:715: if (type === Timeline.TimelineFlameChartDataProvider.EntryType.Frame) ditto.
https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js (right): https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:105: if (entryType === Timeline.TimelineFlameChartDataProvider.EntryType.Event) { On 2017/05/10 18:40:28, caseq wrote: > nit: consider aliasing EntryType to something. Done. https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:470: this._model.maximumRecordTime() - screenshots.peekLast().timestamp; On 2017/05/10 18:40:28, caseq wrote: > just use prevTimestamp? Done. https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:547: if (type === Timeline.TimelineFlameChartDataProvider.EntryType.Event) { On 2017/05/10 18:40:28, caseq wrote: > nit: consider aliasing EntryType to something. Done. https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:652: if (type === Timeline.TimelineFlameChartDataProvider.EntryType.Frame) { On 2017/05/10 18:40:28, caseq wrote: > ditto. Done. https://codereview.chromium.org/2873153002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:715: if (type === Timeline.TimelineFlameChartDataProvider.EntryType.Frame) On 2017/05/10 18:40:28, caseq wrote: > ditto. Done.
The CQ bit was checked by alph@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org Link to the patchset: https://codereview.chromium.org/2873153002/#ps20001 (title: "addressing nits")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494564047999500,
"parent_rev": "b9cc386a43da830e859b92ff63f3b0a8fae75e9f", "commit_rev":
"df53c315ea874b85d78d91b95443a9461c59d225"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: Draw screenshot independently of frames bar on flamechart. BUG=705054 ========== to ========== DevTools: Draw screenshot independently of frames bar on flamechart. BUG=705054 Review-Url: https://codereview.chromium.org/2873153002 Cr-Commit-Position: refs/heads/master@{#471237} Committed: https://chromium.googlesource.com/chromium/src/+/df53c315ea874b85d78d91b95443... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/df53c315ea874b85d78d91b95443... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
