third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js - Issue 2873153002: DevTools: Draw screenshot independently of frames bar on flamechart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

Issue 2873153002: DevTools: Draw screenshot independently of frames bar on flamechart. (Closed)

Patch Set: addressing nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

diff --git a/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

index bba71855f9af3a95385968d5e710e935e7008cfa..5ac5dd82f6e29a7ce98b1976b153dbd25516aba6 100644

--- a/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

@@ -1120,7 +1120,8 @@ PerfUI.FlameChart = class extends PerfUI.ChartViewport {

currentOffset += style.height;

}

var isFirstOnLevel = groupIndex >= 0 && level === groups[groupIndex].startLevel;

- var thisLevelIsVisible = visible || isFirstOnLevel && groups[groupIndex].style.useFirstLineForOverview;

+ var thisLevelIsVisible =

+ parentGroupIsVisible && (visible || isFirstOnLevel && groups[groupIndex].style.useFirstLineForOverview);

if (level < levelCount) {

var height;

if (groupIndex >= 0) {

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js » ('j') | no next file with comments »