Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2873093004:
Update UI strings based on the latest user research. (Closed)
DescriptionUpdate UI strings based on latest user research.
Tested on Nexus 5, some strings might be longer than screen width.
https://screenshot.googleplex.com/Tju4Jpo2VSw
BUG=703887
TBR=dfalcantara@chromium.org
Review-Url: https://codereview.chromium.org/2873093004
Cr-Commit-Position: refs/heads/master@{#472672}
Committed: https://chromium.googlesource.com/chromium/src/+/9c3d5f7e6f7c35d6f32af29a1c5e081afe6b9475
Patch Set 1 #Patch Set 2 : added the "?" #
Total comments: 7
Patch Set 3 : clear desc #Patch Set 4 : merge #Patch Set 5 : Merge branch 'master' into trans-strings #Patch Set 6 : fix not well-format #
Messages
Total messages: 25 (13 generated)
Description was changed from ========== Update UI strings based on latest user research. Tested on Nexus 5, some strings might be longer than screen width. https://screenshot.googleplex.com/Tju4Jpo2VSw BUG=703887 ========== to ========== Update UI strings based on latest user research. Tested on Nexus 5, some strings might be longer than screen width. https://screenshot.googleplex.com/Tju4Jpo2VSw BUG=703887 ==========
googleo@chromium.org changed reviewers: + mdjones@chromium.org, srahim@chromium.org
Update the strings in the new UI. PTAL
lgtm, but why is there so much padding on the left in the screen shot?
On 2017/05/11 16:53:43, mdjones wrote: > lgtm, but why is there so much padding on the left in the screen shot? Implemented by design. These spaces are used to show "checked status" for item, see https://screenshot.googleplex.com/9foMN3KD3pO. We discussed it with our designer and we think the space should be only shown when there is a checked item at least. However our designer thinks this is the right behavior.
Hi Leo, I updated the message descriptions with a bit more detail. https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1590: Never translate pages in <ph name="SOURCE_LANGUAGE">%1$s<ex>French</ex></ph> Please add to message description, before "Imperative.": The variable SOURCE_LANGUAGE could be any of 50+ languages supported by Google Translate, like French, Spanish, German, Italian, Japanese, Korean, etc. https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1596: Page is not in <ph name="LANGUAGE">%1$s<ex>French</ex></ph>? Please update message description: Option in the Chrome menu. Sometimes a web page's source language is not correctly identified by Google Translate, and this menu option lets the user 1) indicate this error to Google, and 2) open a submenu to select another language as the source language to translate. Phrased as a question as if to query the user, "Is this page not in <source language identified>? If so, click here." https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1598: <message name="IDS_TRANSLATE_SNACKBAR_ALWAYS_TRANSLATE" desc="Text to be displayed in translate snackbar that lets the user know pages in this source language will be translated to target language automatically. [CHAR-LIMIT=64]"> Please update message description: After the user selects "Always translate pages in <LANGUAGE>", this text confirms the user's choice and lets them know that pages in <LANGUAGE> will be translated to their chosen target language automatically. Imperative. https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1601: <message name="IDS_TRANSLATE_SNACKBAR_LANGUAGE_NEVER" desc="Text to be displayed in translate snackbar that lets the user know sites in this language will not be translated. [CHAR-LIMIT=64]"> Please update message description: After the user selects "Never translate pages in <LANGUAGE>", this text confirms the user's choice and lets them know that pages in <LANGUAGE> will not be translated to their chosen target language automatically. Imperative.
On 2017/05/15 05:20:09, srahim wrote: > Hi Leo, I updated the message descriptions with a bit more detail. > > https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... > File chrome/android/java/strings/android_chrome_strings.grd (right): > > https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... > chrome/android/java/strings/android_chrome_strings.grd:1590: Never translate > pages in <ph name="SOURCE_LANGUAGE">%1$s<ex>French</ex></ph> > Please add to message description, before "Imperative.": > The variable SOURCE_LANGUAGE could be any of 50+ languages supported by Google > Translate, like French, Spanish, German, Italian, Japanese, Korean, etc. > > https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... > chrome/android/java/strings/android_chrome_strings.grd:1596: Page is not in <ph > name="LANGUAGE">%1$s<ex>French</ex></ph>? > Please update message description: > Option in the Chrome menu. Sometimes a web page's source language is not > correctly identified by Google Translate, and this menu option lets the user 1) > indicate this error to Google, and 2) open a submenu to select another language > as the source language to translate. Phrased as a question as if to query the > user, "Is this page not in <source language identified>? If so, click here." > > https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... > chrome/android/java/strings/android_chrome_strings.grd:1598: <message > name="IDS_TRANSLATE_SNACKBAR_ALWAYS_TRANSLATE" desc="Text to be displayed in > translate snackbar that lets the user know pages in this source language will be > translated to target language automatically. [CHAR-LIMIT=64]"> > Please update message description: > After the user selects "Always translate pages in <LANGUAGE>", this text > confirms the user's choice and lets them know that pages in <LANGUAGE> will be > translated to their chosen target language automatically. Imperative. > > https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... > chrome/android/java/strings/android_chrome_strings.grd:1601: <message > name="IDS_TRANSLATE_SNACKBAR_LANGUAGE_NEVER" desc="Text to be displayed in > translate snackbar that lets the user know sites in this language will not be > translated. [CHAR-LIMIT=64]"> > Please update message description: > After the user selects "Never translate pages in <LANGUAGE>", this text confirms > the user's choice and lets them know that pages in <LANGUAGE> will not be > translated to their chosen target language automatically. Imperative. Just saw your note about Android not supporting language detection errors. Thanks for figuring that out, and so you can remove this text from the relevant message description: "1) indicate this error to Google, and 2)"
Thanks updated the desc of the messages. https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1590: Never translate pages in <ph name="SOURCE_LANGUAGE">%1$s<ex>French</ex></ph> On 2017/05/15 05:20:09, srahim wrote: > Please add to message description, before "Imperative.": > The variable SOURCE_LANGUAGE could be any of 50+ languages supported by Google > Translate, like French, Spanish, German, Italian, Japanese, Korean, etc. Done. https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1596: Page is not in <ph name="LANGUAGE">%1$s<ex>French</ex></ph>? On 2017/05/15 05:20:09, srahim wrote: > Please update message description: > Option in the Chrome menu. Sometimes a web page's source language is not > correctly identified by Google Translate, and this menu option lets the user 1) > indicate this error to Google, and 2) open a submenu to select another language > as the source language to translate. Phrased as a question as if to query the > user, "Is this page not in <source language identified>? If so, click here." Done. https://codereview.chromium.org/2873093004/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1598: <message name="IDS_TRANSLATE_SNACKBAR_ALWAYS_TRANSLATE" desc="Text to be displayed in translate snackbar that lets the user know pages in this source language will be translated to target language automatically. [CHAR-LIMIT=64]"> On 2017/05/15 05:20:09, srahim wrote: > Please update message description: > After the user selects "Always translate pages in <LANGUAGE>", this text > confirms the user's choice and lets them know that pages in <LANGUAGE> will be > translated to their chosen target language automatically. Imperative. Done.
lgtm
Description was changed from ========== Update UI strings based on latest user research. Tested on Nexus 5, some strings might be longer than screen width. https://screenshot.googleplex.com/Tju4Jpo2VSw BUG=703887 ========== to ========== Update UI strings based on latest user research. Tested on Nexus 5, some strings might be longer than screen width. https://screenshot.googleplex.com/Tju4Jpo2VSw BUG=703887 TBR=dfalcantara@chromium.org ==========
The CQ bit was checked by googleo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org, srahim@chromium.org Link to the patchset: https://codereview.chromium.org/2873093004/#ps60001 (title: "merge")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by googleo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org, srahim@chromium.org Link to the patchset: https://codereview.chromium.org/2873093004/#ps80001 (title: "Merge branch 'master' into trans-strings")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by googleo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org, srahim@chromium.org Link to the patchset: https://codereview.chromium.org/2873093004/#ps100001 (title: "fix not well-format")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495081083695410,
"parent_rev": "def869130c7984358d2a7f93a37f135cb34777d5", "commit_rev":
"9c3d5f7e6f7c35d6f32af29a1c5e081afe6b9475"}
Message was sent while issue was closed.
Description was changed from ========== Update UI strings based on latest user research. Tested on Nexus 5, some strings might be longer than screen width. https://screenshot.googleplex.com/Tju4Jpo2VSw BUG=703887 TBR=dfalcantara@chromium.org ========== to ========== Update UI strings based on latest user research. Tested on Nexus 5, some strings might be longer than screen width. https://screenshot.googleplex.com/Tju4Jpo2VSw BUG=703887 TBR=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2873093004 Cr-Commit-Position: refs/heads/master@{#472672} Committed: https://chromium.googlesource.com/chromium/src/+/9c3d5f7e6f7c35d6f32af29a1c5e... ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
