Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java

Issue 2873093004: Update UI strings based on the latest user research. (Closed)
Patch Set: fix not well-format Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
index cceff7bde03f43cab6141cdbd685b69794e3fab3..4ffca735e1e58d1de09bdcaaaa62326f63b6cf7e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
@@ -230,17 +230,18 @@ public class TranslateMenuHelper implements AdapterView.OnItemClickListener {
String source = mOptions.sourceLanguageName();
switch (item.mId) {
case TranslateMenu.ID_OVERFLOW_ALWAYS_TRANSLATE:
- return mContextWrapper.getString(R.string.translate_always_text, source);
+ return mContextWrapper.getString(
+ R.string.translate_option_always_translate, source);
case TranslateMenu.ID_OVERFLOW_MORE_LANGUAGE:
- return mContextWrapper.getString(R.string.translate_infobar_more_language);
+ return mContextWrapper.getString(R.string.translate_option_more_language);
case TranslateMenu.ID_OVERFLOW_NEVER_SITE:
return mContextWrapper.getString(R.string.translate_never_translate_site);
case TranslateMenu.ID_OVERFLOW_NEVER_LANGUAGE:
return mContextWrapper.getString(
- R.string.translate_never_translate_language, source);
+ R.string.translate_option_never_translate, source);
case TranslateMenu.ID_OVERFLOW_NOT_THIS_LANGUAGE:
return mContextWrapper.getString(
- R.string.translate_infobar_not_source_language, source);
+ R.string.translate_option_not_source_language, source);
default:
assert false : "Unexpected Overflow Item Id";
}
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698