Rename EvictFrame, EvictSurface to EvictCurrentSurface

Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface may be submitted with many CompositorFrames, Surface and Frame 
are not the same concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is 
misleading, so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2872883002
Cr-Commit-Position: refs/heads/master@{#471131}
Committed: https://chromium.googlesource.com/chromium/src/+/cdc09d7490c92687a35ebcc1265b0c03c43e8410

[xing.xu, 2017-05-09 05:50:43]

Description was changed from

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface maybe submitted with many CompositorFrames, they are not the same
concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is
misleading,
so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
==========

to

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface maybe submitted with many CompositorFrames, they are not the same
concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is
misleading,
so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xing.xu, 2017-05-09 05:50:45]

Description was changed from

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface maybe submitted with many CompositorFrames, they are not the same
concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is
misleading,
so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface maybe submitted with many CompositorFrames, they are not the same
concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is
misleading,
so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[xing.xu, 2017-05-09 05:51:05]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 05:51:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-05-09 05:52:29]

Description was changed from

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface maybe submitted with many CompositorFrames, they are not the same
concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is
misleading,
so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface maybe submitted with many CompositorFrames, they are not the same
concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is
misleading,
so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[xing.xu, 2017-05-09 05:52:29]

xing.xu@intel.com changed reviewers:
+ boliu@chromium.org, fsamuel@chromium.org, jamescook@chromium.org,
jbauman@chromium.org, reveman@chromium.org, tsepez@chromium.org

[xing.xu, 2017-05-09 06:58:35]

PTAL.

[xing.xu, 2017-05-09 07:01:19]

Description was changed from

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface maybe submitted with many CompositorFrames, they are not the same
concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is
misleading,
so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface may be submitted with many CompositorFrames, Surface and Frame 
are not the same concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is
misleading,
so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[xing.xu, 2017-05-09 07:01:43]

Description was changed from

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface may be submitted with many CompositorFrames, Surface and Frame 
are not the same concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is
misleading,
so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface may be submitted with many CompositorFrames, Surface and Frame 
are not the same concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is 
misleading, so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-05-09 07:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 07:34:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Fady Samuel, 2017-05-09 09:53:49]

lgtm

[reveman, 2017-05-09 11:52:25]

components/exo lgtm

[boliu, 2017-05-09 14:25:28]

when there are multiple reviewers, make sure to point out which directory they
are supposed to review

android_webview, content/browser, ui/android lgtm

[James Cook, 2017-05-09 14:26:26]

ash lgtm

[xing.xu, 2017-05-09 15:28:43]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-05-09 15:29:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-05-09 15:40:38]

Missing LGTM from an OWNER for these files:
    cc/ipc/mojo_compositor_frame_sink.mojom

tsepez@

[commit-bot: I haz the power, 2017-05-09 15:41:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 15:41:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Tom Sepez, 2017-05-09 16:09:39]

RS LGTM on renaming existing method.

[xing.xu, 2017-05-10 00:03:02]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-05-10 00:06:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 02:09:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 02:09:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[xing.xu, 2017-05-10 03:12:34]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-05-10 03:13:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 04:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 04:48:50]

Failed to apply patch for components/exo/compositor_frame_sink.cc:
While running git apply --index -3 -p1;
  error: components/exo/compositor_frame_sink.cc: does not exist in index

Patch:       components/exo/compositor_frame_sink.cc
Index: components/exo/compositor_frame_sink.cc
diff --git a/components/exo/compositor_frame_sink.cc
b/components/exo/compositor_frame_sink.cc
index
cee2955b41b3119d04b52d46837a3571377f3105..69bb5703e3b19e76bbaadfbfb7211102b02b510d
100644
--- a/components/exo/compositor_frame_sink.cc
+++ b/components/exo/compositor_frame_sink.cc
@@ -47,8 +47,8 @@ void CompositorFrameSink::BeginFrameDidNotSwap(
   support_->BeginFrameDidNotSwap(begin_frame_ack);
 }
 
-void CompositorFrameSink::EvictFrame() {
-  support_->EvictFrame();
+void CompositorFrameSink::EvictCurrentSurface() {
+  support_->EvictCurrentSurface();
 }
 

////////////////////////////////////////////////////////////////////////////////

[xing.xu, 2017-05-10 07:51:08]

xing.xu@intel.com changed reviewers:
+ sadrul@chromium.org

[xing.xu, 2017-05-10 07:51:46]

+sadrul@ for ui/aura/local/compositor_frame_sink_local.cc

[xing.xu, 2017-05-10 08:25:36]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 08:25:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 09:49:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 09:49:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[xing.xu, 2017-05-10 12:43:02]

The CQ bit was checked by xing.xu@intel.com

[xing.xu, 2017-05-10 12:43:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, reveman@chromium.org, boliu@chromium.org,
tsepez@chromium.org, fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2872883002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-10 12:43:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 12:52:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 12:52:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xing.xu, 2017-05-11 00:25:07]

xing.xu@intel.com changed reviewers:
+ sky@chromium.org

[xing.xu, 2017-05-11 00:25:21]

Add another owners sky@
for ui/aura/local/compositor_frame_sink_local.cc.

[sky, 2017-05-11 15:19:32]

LGTM

[Fady Samuel, 2017-05-11 17:13:44]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-05-11 17:14:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 17:19:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 17:19:36]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xing.xu, 2017-05-11 21:53:37]

The CQ bit was checked by xing.xu@intel.com

[xing.xu, 2017-05-11 21:53:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, sky@chromium.org, boliu@chromium.org,
fsamuel@chromium.org, tsepez@chromium.org, reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2872883002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-11 21:54:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 00:08:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494539617882790,
"parent_rev": "74728942d3888f8ca976f71a8f90390237540d09", "commit_rev":
"cdc09d7490c92687a35ebcc1265b0c03c43e8410"}

[commit-bot: I haz the power, 2017-05-12 00:09:11]

Description was changed from

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface may be submitted with many CompositorFrames, Surface and Frame 
are not the same concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is 
misleading, so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Rename EvictFrame, EvictSurface to EvictCurrentSurface

A Surface may be submitted with many CompositorFrames, Surface and Frame 
are not the same concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is 
misleading, so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2872883002
Cr-Commit-Position: refs/heads/master@{#471131}
Committed:
https://chromium.googlesource.com/chromium/src/+/cdc09d7490c92687a35ebcc1265b...
==========

[commit-bot: I haz the power, 2017-05-12 00:09:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cdc09d7490c92687a35ebcc1265b...