DevTools: Support grouping by Product in performance tree views.

DevTools: Support grouping by Product in performance tree views.

BUG=718655
Review-Url: https://codereview.chromium.org/2872853002
Cr-Commit-Position: refs/heads/master@{#470275}
Committed: https://chromium.googlesource.com/chromium/src/+/dd4253aaedfc7947ecd92f7755219106a3152642

[alph, 2017-05-09 00:23:18]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-05-09 01:48:32]

lgtm

https://codereview.chromium.org/2872853002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2872853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/Main.js:140:
Runtime.experiments.enableForTest('timelineColorByProduct');
Let's rather do this in tests, use experiment.enableForTest() from an
initialize_Foo() function.

https://codereview.chromium.org/2872853002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
(right):

https://codereview.chromium.org/2872853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:643:
this._productRegistryPromiseForTest = ProductRegistry.instance().then(registry
=> {
Let's try to avoid this.

[alph, 2017-05-09 02:00:14]

https://codereview.chromium.org/2872853002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2872853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/Main.js:140:
Runtime.experiments.enableForTest('timelineColorByProduct');
On 2017/05/09 01:48:32, caseq wrote:
> Let's rather do this in tests, use experiment.enableForTest() from an
> initialize_Foo() function.

Done.

https://codereview.chromium.org/2872853002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
(right):

https://codereview.chromium.org/2872853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:643:
this._productRegistryPromiseForTest = ProductRegistry.instance().then(registry
=> {
On 2017/05/09 01:48:32, caseq wrote:
> Let's try to avoid this.

Done.

[alph, 2017-05-09 02:00:18]

The CQ bit was checked by alph@chromium.org

[alph, 2017-05-09 02:00:18]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2872853002/#ps20001
(title: "addressing comments")

[commit-bot: I haz the power, 2017-05-09 02:03:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 06:23:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 06:23:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alph, 2017-05-09 07:16:32]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-05-09 07:16:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 10:55:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494314192598140,
"parent_rev": "9dc5991e8182ed6fd79e77c5f158af1a420a23be", "commit_rev":
"dd4253aaedfc7947ecd92f7755219106a3152642"}

[commit-bot: I haz the power, 2017-05-09 10:55:51]

Description was changed from

==========
DevTools: Support grouping by Product in performance tree views.

BUG=718655
==========

to

==========
DevTools: Support grouping by Product in performance tree views.

BUG=718655

Review-Url: https://codereview.chromium.org/2872853002
Cr-Commit-Position: refs/heads/master@{#470275}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd4253aaedfc7947ecd92f775521...
==========

[commit-bot: I haz the power, 2017-05-09 10:55:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd4253aaedfc7947ecd92f775521...