third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js - Issue 2872853002: DevTools: Support grouping by Product in performance tree views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

Issue 2872853002: DevTools: Support grouping by Product in performance tree views. (Closed)

Patch Set: addressing comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

index 76cd993abfc0d4544e20bc0f2d61d652dcb8a76d..d61a3a3419ed2bfb43defe02bab94af20d41296e 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

@@ -125,12 +125,11 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {

return Timeline.TimelineUIUtils.eventStyle(event).category.color;

var color = this._urlToColorCache.get(frame.url);

if (!color) {

- var defaultColor = '#f2ecdc';

if (!this._productRegistry)

- return defaultColor;

+ return Timeline.TimelineUIUtils.colorForId('');

var parsedURL = frame.url.asParsedURL();

- var name = parsedURL && this._productRegistry.nameForUrl(parsedURL);

- color = name ? Timeline.TimelineUIUtils.colorForId(name) : defaultColor;

+ var name = parsedURL && this._productRegistry.nameForUrl(parsedURL) || '';

+ color = Timeline.TimelineUIUtils.colorForId(name);

this._urlToColorCache.set(frame.url, color);

}

return color;