Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2872823002: Display the web view after commit for non-user-initiated loads. (Closed)

Created:
3 years, 7 months ago by kkhorimoto
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Display the web view after commit for non-user-initiated loads. The toolbar's visibility and URL is dependent on the visible URL. However, the previous implementation of |-ensureWebViewCreated| would immediately add web view to the hierarchy, even for non-user-initiated loads. This CL updates the web view display logic so that it is displayed at the same time as the toolbar updating. BUG=703222 Review-Url: https://codereview.chromium.org/2820013003 Cr-Commit-Position: refs/heads/master@{#465365} (cherry picked from commit cd2e9b497d8623d1c2844b6df874e42f865c2631) Review-Url: https://codereview.chromium.org/2872823002 . Cr-Commit-Position: refs/branch-heads/3071@{#470} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/f10bd0a68a24c6c58a7f4d67e5dc2d090ddce05c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 5 chunks +32 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kkhorimoto
3 years, 7 months ago (2017-05-08 22:04:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f10bd0a68a24c6c58a7f4d67e5dc2d090ddce05c.

Powered by Google App Engine
This is Rietveld 408576698