Display the web view after commit for non-user-initiated loads.

Display the web view after commit for non-user-initiated loads.

The toolbar's visibility and URL is dependent on the visible URL.
However, the previous implementation of |-ensureWebViewCreated| would
immediately add web view to the hierarchy, even for non-user-initiated
loads.  This CL updates the web view display logic so that it is
displayed at the same time as the toolbar updating.

BUG=703222
Review-Url: https://codereview.chromium.org/2820013003
Cr-Commit-Position: refs/heads/master@{#465365}
Committed: https://chromium.googlesource.com/chromium/src/+/cd2e9b497d8623d1c2844b6df874e42f865c2631

[kkhorimoto, 2017-04-15 00:44:13]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org, justincohen@chromium.org, rohitrao@chromium.org

[Eugene But (OOO till 7-30), 2017-04-15 00:48:51]

https://codereview.chromium.org/2820013003/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2820013003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:4091: if (!self.webView ||
[_containerView webViewContentView])
When web view can be nil?

[kkhorimoto, 2017-04-17 23:42:00]

DCHECK

[kkhorimoto, 2017-04-17 23:42:10]

https://codereview.chromium.org/2820013003/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2820013003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:4091: if (!self.webView ||
[_containerView webViewContentView])
On 2017/04/15 00:48:51, Eugene But wrote:
> When web view can be nil?

It really shouldn't be.  I've changed to use a DCHECK instead.

[Eugene But (OOO till 7-30), 2017-04-18 00:20:13]

lgtm

https://codereview.chromium.org/2820013003/diff/40001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2820013003/diff/40001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:4130: DCHECK(self.webView);
nit: s/self.webView/_webView for consistency with line 4131 ?

[kkhorimoto, 2017-04-18 00:53:25]

self.webView => _webView

[kkhorimoto, 2017-04-18 00:54:13]

Comments have been addressed, but there's still some discussion on the bug as to
whether this is the right approach.  I'll land this when a consensus has been
reached.

https://codereview.chromium.org/2820013003/diff/40001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2820013003/diff/40001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:4130: DCHECK(self.webView);
On 2017/04/18 00:20:13, Eugene But wrote:
> nit: s/self.webView/_webView for consistency with line 4131 ?

Done.

[kkhorimoto, 2017-04-18 17:18:20]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-04-18 17:18:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2820013003/#ps60001
(title: "self.webView => _webView")

[commit-bot: I haz the power, 2017-04-18 17:18:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 20:03:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 20:03:34]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kkhorimoto, 2017-04-18 20:30:52]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-04-18 20:30:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2820013003/#ps80001
(title: "unittest fix")

[commit-bot: I haz the power, 2017-04-18 20:31:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 20:55:36]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492547452650320,
"parent_rev": "ee01a831cd8e163cec02f3ca6196dfb439e89c8f", "commit_rev":
"cd2e9b497d8623d1c2844b6df874e42f865c2631"}

[commit-bot: I haz the power, 2017-04-18 20:55:50]

Description was changed from

==========
Display the web view after commit for non-user-initiated loads.

The toolbar's visibility and URL is dependent on the visible URL.
However, the previous implementation of |-ensureWebViewCreated| would
immediately add web view to the hierarchy, even for non-user-initiated
loads.  This CL updates the web view display logic so that it is
displayed at the same time as the toolbar updating.

BUG=703222
==========

to

==========
Display the web view after commit for non-user-initiated loads.

The toolbar's visibility and URL is dependent on the visible URL.
However, the previous implementation of |-ensureWebViewCreated| would
immediately add web view to the hierarchy, even for non-user-initiated
loads.  This CL updates the web view display logic so that it is
displayed at the same time as the toolbar updating.

BUG=703222

Review-Url: https://codereview.chromium.org/2820013003
Cr-Commit-Position: refs/heads/master@{#465365}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd2e9b497d8623d1c2844b6df874...
==========

[commit-bot: I haz the power, 2017-04-18 20:55:51]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/cd2e9b497d8623d1c2844b6df874...