[Cronet] Regression test for DCHECK when histograms read on another thread

[Cronet] Regression test for DCHECK when histograms read on another thread

BUG=719448
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2872593002
Cr-Commit-Position: refs/heads/master@{#471062}
Committed: https://chromium.googlesource.com/chromium/src/+/942900db95e432adabbb191d3709ad1be86b33ef

[pauljensen, 2017-05-08 12:49:19]

Description was changed from

==========
DO NOT COMMIT - regression test for DCHECK when histograms read on another
thread
==========

to

==========
DO NOT COMMIT - regression test for DCHECK when histograms read on another
thread
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[pauljensen, 2017-05-08 15:02:46]

Description was changed from

==========
DO NOT COMMIT - regression test for DCHECK when histograms read on another
thread
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
DO NOT COMMIT - regression test for DCHECK when histograms read on another
thread

BUG=719448

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[pauljensen, 2017-05-09 15:00:23]

Description was changed from

==========
DO NOT COMMIT - regression test for DCHECK when histograms read on another
thread

BUG=719448

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Regression test for DCHECK when histograms read on another thread

BUG=719448

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[pauljensen, 2017-05-09 15:05:50]

pauljensen@chromium.org changed reviewers:
+ mef@chromium.org

[pauljensen, 2017-05-09 15:05:51]

Misha, PTAL, thank you!

[mef, 2017-05-09 15:13:26]

https://codereview.chromium.org/2872593002/diff/40001/components/cronet/andro...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
(right):

https://codereview.chromium.org/2872593002/diff/40001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java:1162:
assertTrue(delta2.length != 0);
AFAIK JUnit assertions only work properly on the main test thread. 
Can we collect delta2 on worker thread, but perform asserts after cv.block()?

[pauljensen, 2017-05-09 15:55:54]

https://codereview.chromium.org/2872593002/diff/40001/components/cronet/andro...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
(right):

https://codereview.chromium.org/2872593002/diff/40001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java:1162:
assertTrue(delta2.length != 0);
On 2017/05/09 15:13:26, mef wrote:
> AFAIK JUnit assertions only work properly on the main test thread. 
> Can we collect delta2 on worker thread, but perform asserts after cv.block()?

Done.

[mef, 2017-05-11 19:55:17]

lgtm

[pauljensen, 2017-05-11 20:06:47]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2017-05-11 20:07:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 20:40:42]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494533207553240,
"parent_rev": "2b6becedacaa1f65387896b261ae2103e7b5d145", "commit_rev":
"74b53a5e76b06456cfa75eea1bf272ff18178868"}

[commit-bot: I haz the power, 2017-05-11 20:40:56]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494533207553240,
"parent_rev": "ff67881b79d0206fbc26d3f98789547935785cb5", "commit_rev":
"942900db95e432adabbb191d3709ad1be86b33ef"}

[commit-bot: I haz the power, 2017-05-11 20:41:03]

Description was changed from

==========
[Cronet] Regression test for DCHECK when histograms read on another thread

BUG=719448

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Regression test for DCHECK when histograms read on another thread

BUG=719448

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2872593002
Cr-Commit-Position: refs/heads/master@{#471062}
Committed:
https://chromium.googlesource.com/chromium/src/+/942900db95e432adabbb191d3709...
==========

[commit-bot: I haz the power, 2017-05-11 20:41:04]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/942900db95e432adabbb191d3709...