Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 2872593002: [Cronet] Regression test for DCHECK when histograms read on another thread (Closed)
Patch Set: cleanup Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index e0f7186c14df82134c55cc15ae153caaaf79eb29..ea1bd18cae10eaab4ca4458d833b0e27339803e5 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -31,7 +31,9 @@ import java.io.File;
import java.io.FileReader;
import java.net.URL;
import java.util.Arrays;
+import java.util.concurrent.Callable;
import java.util.concurrent.Executor;
+import java.util.concurrent.FutureTask;
import java.util.concurrent.atomic.AtomicReference;
/**
@@ -1152,7 +1154,15 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
mUrl, callback, callback.getExecutor());
builder.build().start();
callback.blockForDone();
- byte delta2[] = testFramework.mCronetEngine.getGlobalMetricsDeltas();
+ // Fetch deltas on a different thread the second time to make sure this is permitted.
+ // See crbug.com/719448
+ FutureTask<byte[]> task = new FutureTask<byte[]>(new Callable<byte[]>() {
+ public byte[] call() {
+ return testFramework.mCronetEngine.getGlobalMetricsDeltas();
+ }
+ });
+ new Thread(task).start();
+ byte delta2[] = task.get();
assertTrue(delta2.length != 0);
assertFalse(Arrays.equals(delta1, delta2));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698