Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2872553004: Rename kNodeTypeJavaScript to kNodeTypeScriptProcessor (Closed)

Created:
3 years, 7 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, haraken, blink-reviews, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename kNodeTypeJavaScript to kNodeTypeScriptProcessor The old Javascript node was renamed to ScriptProcessor long ago. Make the enum match the actual node name. No changes in behavior. BUG=719532 TEST=none Review-Url: https://codereview.chromium.org/2872553004 Cr-Commit-Position: refs/heads/master@{#470184} Committed: https://chromium.googlesource.com/chromium/src/+/cd5c0cc74fa7a0be9318a9cd69460d5fea4c66ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 7 months ago (2017-05-08 16:58:12 UTC) #2
hongchan
lgtm
3 years, 7 months ago (2017-05-08 20:37:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872553004/1
3 years, 7 months ago (2017-05-08 20:57:14 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 04:09:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd5c0cc74fa7a0be9318a9cd6946...

Powered by Google App Engine
This is Rietveld 408576698