Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2872543002: Headless: Move GetUntrustedDevToolsFrameIdForFrameTreeNodeId to public (Closed)

Created:
3 years, 7 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 7 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Headless: Move GetUntrustedDevToolsFrameIdForFrameTreeNodeId to public BUG=546953 Review-Url: https://codereview.chromium.org/2872543002 Cr-Commit-Position: refs/heads/master@{#470095} Committed: https://chromium.googlesource.com/chromium/src/+/e7a29e9c1db694f2ae80f95baf758d00e25d28e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M headless/lib/browser/headless_web_contents_impl.h View 2 chunks +4 lines, -8 lines 0 comments Download
M headless/lib/frame_id_browsertest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M headless/public/headless_web_contents.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Sami
lgtm (assuming you meant to sent this for review)
3 years, 7 months ago (2017-05-08 17:34:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872543002/1
3 years, 7 months ago (2017-05-08 17:44:26 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 20:05:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7a29e9c1db694f2ae80f95baf75...

Powered by Google App Engine
This is Rietveld 408576698