Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: headless/lib/frame_id_browsertest.cc

Issue 2872543002: Headless: Move GetUntrustedDevToolsFrameIdForFrameTreeNodeId to public (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/headless_web_contents_impl.h ('k') | headless/public/headless_web_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/frame_id_browsertest.cc
diff --git a/headless/lib/frame_id_browsertest.cc b/headless/lib/frame_id_browsertest.cc
index 340dfadda334bc6a9e969ce3b4a1ab95dfda4617..e8c7c9b694e2c3286389e7c1f182f264fd63b8fd 100644
--- a/headless/lib/frame_id_browsertest.cc
+++ b/headless/lib/frame_id_browsertest.cc
@@ -239,15 +239,11 @@ class FrameIdTest : public HeadlessAsyncDevTooledBrowserTest,
void OnLoadEventFired(const page::LoadEventFiredParams& params) override {
std::map<std::string, std::string> protocol_handler_url_to_frame_id_;
for (const auto& pair : http_handler_->url_to_frame_tree_node_id_) {
- HeadlessWebContentsImpl* headless_web_contents_impl =
- static_cast<HeadlessWebContentsImpl*>(web_contents_);
// TODO(alexclarke): This will probably break with OOPIF, fix this.
// See https://bugs.chromium.org/p/chromium/issues/detail?id=715924
protocol_handler_url_to_frame_id_[pair.first] =
- headless_web_contents_impl
- ->GetUntrustedDevToolsFrameIdForFrameTreeNodeId(
- headless_web_contents_impl->GetMainFrameRenderProcessId(),
- pair.second);
+ web_contents_->GetUntrustedDevToolsFrameIdForFrameTreeNodeId(
+ web_contents_->GetMainFrameRenderProcessId(), pair.second);
}
EXPECT_THAT(url_to_frame_id_, protocol_handler_url_to_frame_id_);
« no previous file with comments | « headless/lib/browser/headless_web_contents_impl.h ('k') | headless/public/headless_web_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698