Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2872503009: Add very basic initial documentation for cc/README.md (Closed)

Created:
3 years, 7 months ago by pdr.
Modified:
3 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add very basic initial documentation for cc/README.md This patch begins adding documentation for cc/. It is based on [1] with some additional comments by me. [1] https://docs.google.com/document/d/17Z6bHUPcDLjV9G1B-_BNFN4-7PqEmeF2krtmm_Vyr38/edit CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2872503009 Cr-Commit-Position: refs/heads/master@{#470757} Committed: https://chromium.googlesource.com/chromium/src/+/366b2246d6fcba8fd2cef00f3ef03acd53a5d47c

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update per reviewer comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -0 lines) Patch
A cc/README.md View 1 1 chunk +126 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
pdr.
Some entries are left empty, we can add them in review or in followups.
3 years, 7 months ago (2017-05-10 00:25:29 UTC) #3
enne (OOO)
Sure, lgtm to check in. Better some documentation than no documentation, and we can go ...
3 years, 7 months ago (2017-05-10 04:31:05 UTC) #4
danakj
LGTM
3 years, 7 months ago (2017-05-10 14:34:56 UTC) #6
danakj
https://codereview.chromium.org/2872503009/diff/1/cc/README.md File cc/README.md (right): https://codereview.chromium.org/2872503009/diff/1/cc/README.md#newcode3 cc/README.md:3: This directory contains a threaded compositor. Its clients include ...
3 years, 7 months ago (2017-05-10 14:35:18 UTC) #7
chrishtr
Thanks for doing this. https://codereview.chromium.org/2872503009/diff/1/cc/README.md File cc/README.md (right): https://codereview.chromium.org/2872503009/diff/1/cc/README.md#newcode100 cc/README.md:100: To produce a single graphical ...
3 years, 7 months ago (2017-05-10 16:47:26 UTC) #8
enne (OOO)
https://codereview.chromium.org/2872503009/diff/1/cc/README.md File cc/README.md (right): https://codereview.chromium.org/2872503009/diff/1/cc/README.md#newcode100 cc/README.md:100: To produce a single graphical output from multiple inputs? ...
3 years, 7 months ago (2017-05-10 18:14:13 UTC) #9
pdr.
Thanks! Lets (the cc and paint teams) try to keep this up to date. If ...
3 years, 7 months ago (2017-05-10 23:24:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872503009/20001
3 years, 7 months ago (2017-05-10 23:25:15 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 00:01:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/366b2246d6fcba8fd2cef00f3ef0...

Powered by Google App Engine
This is Rietveld 408576698