Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2872403003: Have ResourceLoader use FetchContext::CreateURLLoader (Closed)

Created:
3 years, 7 months ago by yhirano
Modified:
3 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Have ResourceLoader use FetchContext::CreateURLLoader ...instead of using Platform::CreateURLLoader directly BUG=712913 Review-Url: https://codereview.chromium.org/2872403003 Cr-Commit-Position: refs/heads/master@{#471214} Committed: https://chromium.googlesource.com/chromium/src/+/75bad4f7e1b204142c189666bf8d268a3a36d6aa

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h View 1 2 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
yhirano
3 years, 7 months ago (2017-05-11 09:15:28 UTC) #8
kinuko
lgtm
3 years, 7 months ago (2017-05-11 09:17:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872403003/20001
3 years, 7 months ago (2017-05-12 02:19:08 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 03:58:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/75bad4f7e1b204142c189666bf8d...

Powered by Google App Engine
This is Rietveld 408576698