Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2868773002:
Have PingLoader use FetchContext::CreateURLLoader (Closed)
DescriptionHave PingLoader use FetchContext::CreateURLLoader
...instead of using Platform::CreateURLLoader directly
BUG=712913
Review-Url: https://codereview.chromium.org/2868773002
Cr-Commit-Position: refs/heads/master@{#470890}
Committed: https://chromium.googlesource.com/chromium/src/+/6eae3c8d8753e442119f88ff2c5464cddcbe196f
Patch Set 1 #Patch Set 2 : done #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 26 (22 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yhirano@chromium.org changed reviewers: + kinuko@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhirano@chromium.org
The CQ bit was unchecked by yhirano@chromium.org
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494494504056270,
"parent_rev": "d54f936badc7666b7b0fb09c545942836e4e9943", "commit_rev":
"6eae3c8d8753e442119f88ff2c5464cddcbe196f"}
Message was sent while issue was closed.
Description was changed from ========== Have PingLoader use FetchContext::CreateURLLoader ...instead of using Platform::CreateURLLoader directly BUG=712913 ========== to ========== Have PingLoader use FetchContext::CreateURLLoader ...instead of using Platform::CreateURLLoader directly BUG=712913 Review-Url: https://codereview.chromium.org/2868773002 Cr-Commit-Position: refs/heads/master@{#470890} Committed: https://chromium.googlesource.com/chromium/src/+/6eae3c8d8753e442119f88ff2c54... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6eae3c8d8753e442119f88ff2c54... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
