Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2872203002: Use default shadow elevation. (Closed)

Created:
3 years, 7 months ago by oshima
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Use default shadow elevation. * Setting medium always use medium regardless of the active state. BUG=719415 TEST=manual. Start ARC app and activate deactivate. Review-Url: https://codereview.chromium.org/2870613002 Cr-Commit-Position: refs/heads/master@{#470156} (cherry picked from commit 34e7e8f91cf42bbe67ff86b75e3aa616046ccccd) Review-Url: https://codereview.chromium.org/2872203002 . Cr-Commit-Position: refs/branch-heads/3029@{#837} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/5948bc0ef082e16b113f5158ef5d04f3b488ce4b

Patch Set 1 #

Patch Set 2 : Use default shadow elevation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/exo/shell_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/shell_surface_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
3 years, 7 months ago (2017-05-10 05:17:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5948bc0ef082e16b113f5158ef5d04f3b488ce4b.

Powered by Google App Engine
This is Rietveld 408576698