Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2872033004: Use is_same_document term instead of is_in_page in NavigationController. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use is_same_document term instead of is_in_page in NavigationController. Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. BUG=695189 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2872033004 Cr-Commit-Position: refs/heads/master@{#470718} Committed: https://chromium.googlesource.com/chromium/src/+/604866f62c0eddbe28e155f124935069398dfed0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M content/browser/frame_host/navigation_controller_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 9 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-05-10 16:51:14 UTC) #7
Charlie Reis
LGTM!
3 years, 7 months ago (2017-05-10 20:52:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872033004/1
3 years, 7 months ago (2017-05-10 21:23:24 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 21:35:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/604866f62c0eddbe28e155f12493...

Powered by Google App Engine
This is Rietveld 408576698