Use is_same_document term instead of is_in_page in NavigationController.

Use is_same_document term instead of is_in_page in NavigationController.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2872033004
Cr-Commit-Position: refs/heads/master@{#470718}
Committed: https://chromium.googlesource.com/chromium/src/+/604866f62c0eddbe28e155f124935069398dfed0

[Eugene But (OOO till 7-30), 2017-05-10 15:30:55]

Description was changed from

==========
Use is_same_document term instead of is_in_page in NavigationController.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
==========

to

==========
Use is_same_document term instead of is_in_page in NavigationController.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Eugene But (OOO till 7-30), 2017-05-10 15:31:33]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 15:32:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 16:49:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 16:49:40]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-10 16:51:14]

eugenebut@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2017-05-10 20:52:35]

LGTM!

[Eugene But (OOO till 7-30), 2017-05-10 21:21:54]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-05-10 21:23:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 21:35:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494451314261340, "parent_rev":
"3de308cf223322e364f6c5621c84443190a8288a", "commit_rev":
"604866f62c0eddbe28e155f124935069398dfed0"}

[commit-bot: I haz the power, 2017-05-10 21:35:50]

Description was changed from

==========
Use is_same_document term instead of is_in_page in NavigationController.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Use is_same_document term instead of is_in_page in NavigationController.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2872033004
Cr-Commit-Position: refs/heads/master@{#470718}
Committed:
https://chromium.googlesource.com/chromium/src/+/604866f62c0eddbe28e155f12493...
==========

[commit-bot: I haz the power, 2017-05-10 21:35:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/604866f62c0eddbe28e155f12493...