Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 2872033004: Use is_same_document term instead of is_in_page in NavigationController. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 // changed, or false if not. 269 // changed, or false if not.
270 // 270 //
271 // The NewPage and NewSubframe functions take in |replace_entry| to pass to 271 // The NewPage and NewSubframe functions take in |replace_entry| to pass to
272 // InsertOrReplaceEntry, in case the newly created NavigationEntry is meant to 272 // InsertOrReplaceEntry, in case the newly created NavigationEntry is meant to
273 // replace the current one (e.g., for location.replace or successful loads 273 // replace the current one (e.g., for location.replace or successful loads
274 // after net errors), in contrast to updating a NavigationEntry in place 274 // after net errors), in contrast to updating a NavigationEntry in place
275 // (e.g., for history.replaceState). 275 // (e.g., for history.replaceState).
276 void RendererDidNavigateToNewPage( 276 void RendererDidNavigateToNewPage(
277 RenderFrameHostImpl* rfh, 277 RenderFrameHostImpl* rfh,
278 const FrameHostMsg_DidCommitProvisionalLoad_Params& params, 278 const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
279 bool is_in_page, 279 bool is_same_document,
280 bool replace_entry, 280 bool replace_entry,
281 NavigationHandleImpl* handle); 281 NavigationHandleImpl* handle);
282 void RendererDidNavigateToExistingPage( 282 void RendererDidNavigateToExistingPage(
283 RenderFrameHostImpl* rfh, 283 RenderFrameHostImpl* rfh,
284 const FrameHostMsg_DidCommitProvisionalLoad_Params& params, 284 const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
285 bool is_in_page, 285 bool is_same_document,
286 bool was_restored, 286 bool was_restored,
287 NavigationHandleImpl* handle); 287 NavigationHandleImpl* handle);
288 void RendererDidNavigateToSamePage( 288 void RendererDidNavigateToSamePage(
289 RenderFrameHostImpl* rfh, 289 RenderFrameHostImpl* rfh,
290 const FrameHostMsg_DidCommitProvisionalLoad_Params& params, 290 const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
291 NavigationHandleImpl* handle); 291 NavigationHandleImpl* handle);
292 void RendererDidNavigateNewSubframe( 292 void RendererDidNavigateNewSubframe(
293 RenderFrameHostImpl* rfh, 293 RenderFrameHostImpl* rfh,
294 const FrameHostMsg_DidCommitProvisionalLoad_Params& params, 294 const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
295 bool is_in_page, 295 bool is_same_document,
296 bool replace_entry); 296 bool replace_entry);
297 bool RendererDidNavigateAutoSubframe( 297 bool RendererDidNavigateAutoSubframe(
298 RenderFrameHostImpl* rfh, 298 RenderFrameHostImpl* rfh,
299 const FrameHostMsg_DidCommitProvisionalLoad_Params& params); 299 const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
300 300
301 // Actually issues the navigation held in pending_entry. 301 // Actually issues the navigation held in pending_entry.
302 void NavigateToPendingEntry(ReloadType reload_type); 302 void NavigateToPendingEntry(ReloadType reload_type);
303 303
304 // Allows the derived class to issue notifications that a load has been 304 // Allows the derived class to issue notifications that a load has been
305 // committed. This will fill in the active entry to the details structure. 305 // committed. This will fill in the active entry to the details structure.
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 // these are ReloadType::NONE and a null timestamp, respectively. 453 // these are ReloadType::NONE and a null timestamp, respectively.
454 ReloadType last_committed_reload_type_; 454 ReloadType last_committed_reload_type_;
455 base::Time last_committed_reload_time_; 455 base::Time last_committed_reload_time_;
456 456
457 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl); 457 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl);
458 }; 458 };
459 459
460 } // namespace content 460 } // namespace content
461 461
462 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 462 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698