[Chromedriver] Do not pass --verbose in testDisablingDriverLogsSuppressesChromeDriverLog.

[Chromedriver] Do not pass --verbose in testDisablingDriverLogsSuppressesChromeDriverLog.

BUG=chromedriver:1805
Review-Url: https://codereview.chromium.org/2871993004
Cr-Commit-Position: refs/heads/master@{#473667}
Committed: https://chromium.googlesource.com/chromium/src/+/c28017fd850d3035cdfc11d688e07331d1e577fe

[gmanikpure, 2017-05-09 21:41:18]

Description was changed from

==========
[Chromedriver] Do not pass --verbose for
testDisablingDriverLogsSuppressesChromeDriverLog.

Please see https://bugs.chromium.org/p/chromedriver/issues/detail?id=1805#c2 for
more details.

BUG=chromedriver:1805
==========

to

==========
[Chromedriver] Do not pass --verbose for
testDisablingDriverLogsSuppressesChromeDriverLog.

BUG=chromedriver:1805
==========

[gmanikpure, 2017-05-09 21:43:21]

Description was changed from

==========
[Chromedriver] Do not pass --verbose for
testDisablingDriverLogsSuppressesChromeDriverLog.

BUG=chromedriver:1805
==========

to

==========
[Chromedriver] Do not pass --verbose in
testDisablingDriverLogsSuppressesChromeDriverLog.

BUG=chromedriver:1805
==========

[gmanikpure, 2017-05-09 21:45:35]

gmanikpure@chromium.org changed reviewers:
+ johnchen@chromium.org, stgao@chromium.org

[gmanikpure, 2017-05-09 21:45:36]

Hi John,

Could you please take a look? Please see more details at
https://bugs.chromium.org/p/chromedriver/issues/detail?id=1805#c2

Thanks,
Gauri

[johnchen, 2017-05-11 23:37:12]

https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/se...
File chrome/test/chromedriver/server/server.py (right):

https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/se...
chrome/test/chromedriver/server/server.py:30: if not verbose and log_path:
I would organize the code a little differently, something like

if log_path:
  ...extend([--log-path...
  if verbose:
    ...extend(['--verbose'])

This avoids duplicating the formatting of log-path switch.

[gmanikpure, 2017-05-11 23:42:46]

https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/se...
File chrome/test/chromedriver/server/server.py (right):

https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/se...
chrome/test/chromedriver/server/server.py:30: if not verbose and log_path:
On 2017/05/11 23:37:11, johnchen wrote:
> I would organize the code a little differently, something like
> 
> if log_path:
>   ...extend([--log-path...
>   if verbose:
>     ...extend(['--verbose'])
> 
> This avoids duplicating the formatting of log-path switch.

Thanks for the suggestion, John. I will make the change and send it for review.

[gmanikpure, 2017-05-12 01:29:11]

https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/se...
File chrome/test/chromedriver/server/server.py (right):

https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/se...
chrome/test/chromedriver/server/server.py:30: if not verbose and log_path:
On 2017/05/11 23:37:11, johnchen wrote:
> I would organize the code a little differently, something like
> 
> if log_path:
>   ...extend([--log-path...
>   if verbose:
>     ...extend(['--verbose'])
> 
> This avoids duplicating the formatting of log-path switch.

Done. Please take a look. Thanks.

[johnchen, 2017-05-12 01:37:11]

LGTM. Thanks!

[gmanikpure, 2017-05-12 15:38:27]

Thanks John!

Hi Shuotao,

CL needs your approval. Could you please take a look?

Thanks,
Gauri

[stgao, 2017-05-22 17:11:43]

lgtm

[gmanikpure, 2017-05-22 19:50:16]

The CQ bit was checked by gmanikpure@chromium.org

[commit-bot: I haz the power, 2017-05-22 19:50:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 20:01:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495482616827320,
"parent_rev": "8d52fb787ae3f370ba1bf7be4b15ae01287879ac", "commit_rev":
"c28017fd850d3035cdfc11d688e07331d1e577fe"}

[commit-bot: I haz the power, 2017-05-22 20:01:21]

Description was changed from

==========
[Chromedriver] Do not pass --verbose in
testDisablingDriverLogsSuppressesChromeDriverLog.

BUG=chromedriver:1805
==========

to

==========
[Chromedriver] Do not pass --verbose in
testDisablingDriverLogsSuppressesChromeDriverLog.

BUG=chromedriver:1805

Review-Url: https://codereview.chromium.org/2871993004
Cr-Commit-Position: refs/heads/master@{#473667}
Committed:
https://chromium.googlesource.com/chromium/src/+/c28017fd850d3035cdfc11d688e0...
==========

[commit-bot: I haz the power, 2017-05-22 20:01:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c28017fd850d3035cdfc11d688e0...