Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2871993004: [Chromedriver] Do not pass --verbose in testDisablingDriverLogsSuppressesChromeDriverLog. (Closed)

Created:
3 years, 7 months ago by gmanikpure
Modified:
3 years, 7 months ago
Reviewers:
johnchen, stgao
CC:
chromium-reviews, johnchen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Do not pass --verbose in testDisablingDriverLogsSuppressesChromeDriverLog. BUG=chromedriver:1805 Review-Url: https://codereview.chromium.org/2871993004 Cr-Commit-Position: refs/heads/master@{#473667} Committed: https://chromium.googlesource.com/chromium/src/+/c28017fd850d3035cdfc11d688e07331d1e577fe

Patch Set 1 #

Total comments: 3

Patch Set 2 : reorganize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/test/chromedriver/server/server.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
gmanikpure
Hi John, Could you please take a look? Please see more details at https://bugs.chromium.org/p/chromedriver/issues/detail?id=1805#c2 Thanks, ...
3 years, 7 months ago (2017-05-09 21:45:36 UTC) #4
johnchen
https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/server/server.py File chrome/test/chromedriver/server/server.py (right): https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/server/server.py#newcode30 chrome/test/chromedriver/server/server.py:30: if not verbose and log_path: I would organize the ...
3 years, 7 months ago (2017-05-11 23:37:12 UTC) #5
gmanikpure
https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/server/server.py File chrome/test/chromedriver/server/server.py (right): https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/server/server.py#newcode30 chrome/test/chromedriver/server/server.py:30: if not verbose and log_path: On 2017/05/11 23:37:11, johnchen ...
3 years, 7 months ago (2017-05-11 23:42:46 UTC) #6
gmanikpure
https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/server/server.py File chrome/test/chromedriver/server/server.py (right): https://codereview.chromium.org/2871993004/diff/1/chrome/test/chromedriver/server/server.py#newcode30 chrome/test/chromedriver/server/server.py:30: if not verbose and log_path: On 2017/05/11 23:37:11, johnchen ...
3 years, 7 months ago (2017-05-12 01:29:11 UTC) #7
johnchen
LGTM. Thanks!
3 years, 7 months ago (2017-05-12 01:37:11 UTC) #8
gmanikpure
Thanks John! Hi Shuotao, CL needs your approval. Could you please take a look? Thanks, ...
3 years, 7 months ago (2017-05-12 15:38:27 UTC) #9
stgao
lgtm
3 years, 7 months ago (2017-05-22 17:11:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871993004/20001
3 years, 7 months ago (2017-05-22 19:50:55 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 20:01:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c28017fd850d3035cdfc11d688e0...

Powered by Google App Engine
This is Rietveld 408576698