Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: chrome/test/chromedriver/server/server.py

Issue 2871993004: [Chromedriver] Do not pass --verbose in testDisablingDriverLogsSuppressesChromeDriverLog. (Closed)
Patch Set: reorganize Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/chromedriver/test/run_py_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/server/server.py
diff --git a/chrome/test/chromedriver/server/server.py b/chrome/test/chromedriver/server/server.py
index 2023e2b03e0a8c724f450c11de0dd8534793894a..dc9539628c3646cd142fe09b6804bb2d5d7b4668 100644
--- a/chrome/test/chromedriver/server/server.py
+++ b/chrome/test/chromedriver/server/server.py
@@ -13,7 +13,7 @@ import urllib2
class Server(object):
"""A running ChromeDriver server."""
- def __init__(self, exe_path, log_path=None):
+ def __init__(self, exe_path, log_path=None, verbose=True):
"""Starts the ChromeDriver server and waits for it to be ready.
Args:
@@ -28,7 +28,9 @@ class Server(object):
port = self._FindOpenPort()
chromedriver_args = [exe_path, '--port=%d' % port]
if log_path:
- chromedriver_args.extend(['--verbose', '--log-path=%s' % log_path])
+ chromedriver_args.extend(['--log-path=%s' %log_path])
+ if verbose:
+ chromedriver_args.extend(['--verbose'])
self._process = subprocess.Popen(chromedriver_args)
self._url = 'http://127.0.0.1:%d' % port
if self._process is None:
« no previous file with comments | « no previous file | chrome/test/chromedriver/test/run_py_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698