Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2871983002: blink: Remove CHECK_CONSISTENCY. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
kojii, eae
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, cbiesinger
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

blink: Remove CHECK_CONSISTENCY. This conditional build mode was added almost a decade ago in http://bugs.webkig.org/show_bug.cgi?id=14981 and the code guarded by it hasn't been compiling in a few weeks at least. It's probably safe to say that it hasn't been used in a long time. BUG=675877 Review-Url: https://codereview.chromium.org/2871983002 Cr-Commit-Position: refs/heads/master@{#471111} Committed: https://chromium.googlesource.com/chromium/src/+/e56e395b65eb473d5f0814a8e870e75632c76229

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -109 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutText.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 5 chunks +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.h View 3 chunks +2 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 4 chunks +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBoxList.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBoxList.cpp View 7 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 63 (35 generated)
Nico
3 years, 7 months ago (2017-05-09 15:36:07 UTC) #3
cbiesinger
I don't know inline layout that well, adding some people who do, they're probably better ...
3 years, 7 months ago (2017-05-09 15:39:16 UTC) #6
eae
LGTM, yeah that code no longer makes sense. Thank you.
3 years, 7 months ago (2017-05-09 15:44:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/1
3 years, 7 months ago (2017-05-09 15:46:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/335267) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-09 16:24:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-09 19:19:48 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/335510) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-09 22:40:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-10 00:58:30 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 03:01:13 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-10 03:25:24 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-10 04:12:43 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449615)
3 years, 7 months ago (2017-05-10 08:20:09 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-10 13:14:45 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450059)
3 years, 7 months ago (2017-05-10 15:21:29 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-10 15:34:39 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450171)
3 years, 7 months ago (2017-05-10 17:27:33 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-10 17:29:37 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/423208)
3 years, 7 months ago (2017-05-10 19:30:31 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-10 19:37:13 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450637)
3 years, 7 months ago (2017-05-10 22:05:09 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-11 13:27:50 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451720)
3 years, 7 months ago (2017-05-11 15:21:03 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-11 15:23:35 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451833)
3 years, 7 months ago (2017-05-11 17:06:45 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-11 19:05:36 UTC) #55
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452156)
3 years, 7 months ago (2017-05-11 21:37:34 UTC) #57
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871983002/20001
3 years, 7 months ago (2017-05-11 21:39:15 UTC) #59
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 23:09:26 UTC) #63
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e56e395b65eb473d5f0814a8e870...

Powered by Google App Engine
This is Rietveld 408576698