Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

Issue 2871983002: blink: Remove CHECK_CONSISTENCY. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
index b29697600454fc8084e3c18a6dccf8a9d188bf41..fb1fa868a2ad2b08017f3ecb109531ef299f737e 100644
--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
@@ -95,7 +95,6 @@ void InlineFlowBox::AddToLine(InlineBox* child) {
DCHECK(!child->Parent());
DCHECK(!child->NextOnLine());
DCHECK(!child->PrevOnLine());
- CheckConsistency();
child->SetParent(this);
if (!first_child_) {
@@ -195,13 +194,9 @@ void InlineFlowBox::AddToLine(InlineBox* child) {
!ToInlineFlowBox(child)->KnownToHaveNoOverflow())
ClearKnownToHaveNoOverflow();
}
-
- CheckConsistency();
}
void InlineFlowBox::RemoveChild(InlineBox* child, MarkLineBoxes mark_dirty) {
- CheckConsistency();
-
if (mark_dirty == kMarkLineBoxesDirty && !IsDirty())
DirtyLineBoxes();
@@ -217,8 +212,6 @@ void InlineFlowBox::RemoveChild(InlineBox* child, MarkLineBoxes mark_dirty) {
child->PrevOnLine()->SetNextOnLine(child->NextOnLine());
child->SetParent(nullptr);
-
- CheckConsistency();
}
void InlineFlowBox::DeleteLine() {
@@ -1720,21 +1713,4 @@ void InlineFlowBox::ShowLineTreeAndMark(const InlineBox* marked_box1,
#endif
-#if DCHECK_IS_ON()
-void InlineFlowBox::CheckConsistency() const {
-#ifdef CHECK_CONSISTENCY
- DCHECK(!m_hasBadChildList);
- const InlineBox* prev = nullptr;
- for (const InlineBox* child = m_firstChild; child;
- child = child->nextOnLine()) {
- DCHECK_EQ(child->parent(), this);
- DCHECK_EQ(child->prevOnLine(), prev);
- prev = child;
- }
- DCHECK_EQ(prev, m_lastChild);
-#endif
-}
-
-#endif
-
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/layout/line/InlineFlowBox.h ('k') | third_party/WebKit/Source/core/layout/line/LineBoxList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698